Issue 558663002: Fix deoptimization of the count operation in Turbofan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 558663002: Fix deoptimization of the count operation in Turbofan. (Closed)

Created:
6 years, 3 months ago by Jarin

Modified:
6 years, 3 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Fix deoptimization of the count operation in Turbofan. BUG=

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/compiler/ast-graph-builder.cc	View		3 chunks	+6 lines, -0 lines	1 comment	Download
	M	test/mjsunit/regress/poly_count_operation.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jarin

On 2014/09/09 17:31:17, jarin wrote: > Could you take a look, please? ping.

6 years, 3 months ago (2014-09-10 15:10:21 UTC) #3

Michael Starzinger

6 years, 3 months ago (2014-09-10 21:38:38 UTC) #4

https://codereview.chromium.org/558663002/diff/1/src/compiler/ast-graph-build...
File src/compiler/ast-graph-builder.cc (right):

https://codereview.chromium.org/558663002/diff/1/src/compiler/ast-graph-build...
src/compiler/ast-graph-builder.cc:1435: environment()->Push(value);
This is approaching crankshaft-esque complexity levels. I cannot even judge
anymore whether this is correct or not. Need to breed over it a little longer
tomorrow.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages