media/video/capture/video_capture_types.h - Issue 558623002: Video capture: Refactor GetBestMatchedFormat from Win to OS independent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/capture/video_capture_types.h

Issue 558623002: Video capture: Refactor GetBestMatchedFormat from Win to OS independent (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sort pixel formats in order of preference Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/video/capture/video_capture_device.cc ('K') | « media/video/capture/video_capture_device.cc ('k') | media/video/capture/win/capability_list_win.h » ('j') | media/video/capture/win/capability_list_win.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/video/capture/video_capture_types.h

diff --git a/media/video/capture/video_capture_types.h b/media/video/capture/video_capture_types.h

index 36cc54ad827955005e5fd566afa1dae78dfb1f29..9eee9cf8f3b8e214b7544cb303bb65d15248a00b 100644

--- a/media/video/capture/video_capture_types.h

+++ b/media/video/capture/video_capture_types.h

@@ -16,18 +16,18 @@ namespace media {

// shared with device manager.

typedef int VideoCaptureSessionId;

-// Color formats from camera.

+// Color formats from camera. This list is sorted in order of preference.

enum VideoPixelFormat {

mcasas 2014/10/13 08:18:45 You have to update histograms.xml as well https://

- PIXEL_FORMAT_UNKNOWN, // Color format not set.

PIXEL_FORMAT_I420,

- PIXEL_FORMAT_YUY2,

+ PIXEL_FORMAT_YV12,

+ PIXEL_FORMAT_NV21,

PIXEL_FORMAT_UYVY,

+ PIXEL_FORMAT_YUY2,

PIXEL_FORMAT_RGB24,

PIXEL_FORMAT_ARGB,

PIXEL_FORMAT_MJPEG,

- PIXEL_FORMAT_NV21,

- PIXEL_FORMAT_YV12,

PIXEL_FORMAT_TEXTURE, // Capture format as a GL texture.

+ PIXEL_FORMAT_UNKNOWN, // Color format not set.

PIXEL_FORMAT_MAX,

};