Video capture: Refactor GetBestMatchedFormat from Win to OS independent

media/video/capture/video_capture_device.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/video/capture/video_capture_device.h"
 
+#include <cmath>
+
 #include "base/i18n/timezone.h"
 #include "base/strings/string_util.h"
 
 namespace media {
 
 const std::string VideoCaptureDevice::Name::GetNameAndModel() const {
   const std::string model_id = GetModel();
   if (model_id.empty())
     return device_name_;
   const std::string suffix = " (" + model_id + ")";
@@ skipping 61 matching lines @@
   }
   return kPowerLine60Hz;
 }
 
 bool VideoCaptureDevice::InitializeImageCapture(
     const ImageCaptureFormat& image_format,
     scoped_ptr<ImageClient> client) {
   return false;
 }
 
+uint64_t DiffVideoCaptureFormat(const VideoCaptureFormat& requested,
+                                const VideoCaptureFormat& supported) {
+  const uint64_t diff_width =
+      std::abs(requested.frame_size.width() - supported.frame_size.width());
+  const uint64_t diff_height =
+      std::abs(requested.frame_size.height() - supported.frame_size.height());
+  // We need to distinguish between rational frame rates (e.g. 29.97 and 30.0).
+  // Therefore, multiply with a large constant before converting to int.
+  const uint64_t diff_frame_rate = static_cast<uint64_t>(
+      kFrameRatePrecision *
+      std::fabs(requested.frame_rate - supported.frame_rate));
+  const uint64_t diff_color_format = supported.pixel_format;

[perkj_chrome, 2014/10/10 09:17:13]

I am afraid that pixelformat is not really sorted in the order of preference.
Can we move YV12 to just below I420 and document in that list that it s sorted.

[magjed_chromium, 2014/10/10 11:21:26]

Done.

+
+  const int resolution_bit_size = 16;

[perkj_chrome, 2014/10/10 09:17:13]

nit:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Constant_Names

[magjed_chromium, 2014/10/10 11:21:25]

These constants are in local scope, so it's ok to use the usual variable naming:
"This convention may optionally be used for compile-time constants of local
scope; otherwise the usual variable naming rules apply."

+  const int frame_rate_bit_size = 24;
+  const int color_format_bit_size = 8;
+
+  DCHECK(diff_width < (1 << resolution_bit_size));
+  DCHECK(diff_height < (1 << resolution_bit_size));
+  DCHECK(diff_frame_rate < (1 << frame_rate_bit_size));
+  DCHECK(diff_color_format < (1 << color_format_bit_size));
+
+  uint64_t distance = diff_height;
+  distance = diff_width | (distance << resolution_bit_size);
+  distance = diff_frame_rate | (distance << frame_rate_bit_size);
+  distance = diff_color_format | (distance << color_format_bit_size);
+  return distance;
+}
+
 }  // namespace media