Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 558613002: [DevTools] Explicitly add Tethering domain to browser protocol. (Closed)

Created:
6 years, 3 months ago by dgozman
Modified:
6 years, 3 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Explicitly add Tethering domain to browser protocol. This is a step to unifying different domains handling and using code generation later. BUG=none Committed: https://crrev.com/d83e88b1d0d8c8cabc2bf7f971f7cf55e10b691e Cr-Commit-Position: refs/heads/master@{#293966}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -41 lines) Patch
M chrome/browser/devtools/BUILD.gn View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/devtools/device/port_forwarding_controller.cc View 8 chunks +18 lines, -15 lines 0 comments Download
M chrome/browser/devtools/devtools_protocol_constants.gyp View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/devtools/browser_protocol.json View 1 chunk +34 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_http_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/tethering_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/tethering_handler.cc View 7 chunks +16 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please. I'm not sure whether we should put browser_protocol to content/public/browser. WDYT?
6 years, 3 months ago (2014-09-09 12:07:03 UTC) #3
pfeldman
lgtm. We should not put it into content/public/browser.
6 years, 3 months ago (2014-09-09 16:39:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgozman@chromium.org/558613002/20001
6 years, 3 months ago (2014-09-09 17:23:45 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 12b5b5a12396c1868eddcfea90511be7e69fddb3
6 years, 3 months ago (2014-09-09 18:11:08 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d83e88b1d0d8c8cabc2bf7f971f7cf55e10b691e
Cr-Commit-Position: refs/heads/master@{#293966}

Powered by Google App Engine
This is Rietveld 408576698