Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8614)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/sync_file_system/drive_backend/folder_creator.cc

Issue 558603002: [SyncFS] Make MetadataDatabase operations synchronous (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@01_create
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/list_changes_task.cc » ('j') | chrome/browser/sync_file_system/drive_backend/list_changes_task.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_backend/folder_creator.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/folder_creator.cc b/chrome/browser/sync_file_system/drive_backend/folder_creator.cc
index 6176ed4d1a8fb8039f96adfa12bafb979cb2f846..c4a902bb11ad50b3e3ff76c49de0bbe30e11174d 100644
--- a/chrome/browser/sync_file_system/drive_backend/folder_creator.cc
+++ b/chrome/browser/sync_file_system/drive_backend/folder_creator.cc
@@ -113,10 +113,8 @@ void FolderCreator::DidListFolders(
std::string file_id = oldest->file_id();
- metadata_database_->UpdateByFileResourceList(
- candidates.Pass(), base::Bind(&FolderCreator::DidUpdateDatabase,
- weak_ptr_factory_.GetWeakPtr(),
- file_id, callback));
+ status = metadata_database_->UpdateByFileResourceList(candidates.Pass());
+ DidUpdateDatabase(file_id, callback, status);
peria 2014/09/10 00:24:15 Expand DidUpdateDatabase() here.
tzik 2014/09/10 00:56:54 Added TODO comment. Can I do it in a separate CL?
}
void FolderCreator::DidUpdateDatabase(const std::string& file_id,
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/conflict_resolver_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/list_changes_task.cc » ('j') | chrome/browser/sync_file_system/drive_backend/list_changes_task.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698