Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 558593003: DevTools: Code clean up in CodeGeneratorInspector.py (Closed)

Created:
6 years, 3 months ago by sergeyv
Modified:
6 years, 3 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Code clean up in CodeGeneratorInspector.py * Get rid of unused methods * Get rid of code duplication * Ease return values: Classes with a static string field are replaced with a string BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181967

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -118 lines) Patch
M Source/core/inspector/CodeGeneratorInspector.py View 23 chunks +13 lines, -118 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sergeyv
6 years, 3 months ago (2014-09-12 15:43:17 UTC) #2
yurys
lgtm
6 years, 3 months ago (2014-09-14 12:20:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558593003/1
6 years, 3 months ago (2014-09-15 07:52:06 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 08:59:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181967

Powered by Google App Engine
This is Rietveld 408576698