Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Issue 558593002: Hydrogen: bailout when there is a throw statement in a non-effect context. (Closed)

Created:
6 years, 3 months ago by Jakob Kummerow
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Hydrogen: bailout when there is a throw statement in a non-effect context. This mirrors the behavior of the compilation pipeline before recent OptimizeFunctionOnNextCall changes. BUG=chromium:412208 LOG=n R=jarin@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -14 lines) Patch
M src/hydrogen.cc View 1 chunk +6 lines, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-412208.js View 1 chunk +5 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jakob Kummerow
6 years, 3 months ago (2014-09-09 09:19:40 UTC) #1
Jarin
lgtm
6 years, 3 months ago (2014-09-09 09:43:16 UTC) #2
Vyacheslav Egorov (Google)
DBC: CL description does not match the content. Probably *not* is missing "bailout when there ...
6 years, 3 months ago (2014-09-09 10:57:59 UTC) #4
Jakob Kummerow
6 years, 3 months ago (2014-09-09 12:16:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698