Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 55853002: Handle empty lines in the 'TimingsAndSettings' state in the WebVTTParser (Closed)

Created:
7 years, 1 month ago by fs
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, philipj_slow, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Handle empty lines in the 'TimingsAndSettings' state in the WebVTTParser As per the WebVTT parsing specification, step 27 ("If line is the empty string, then discard cue and jump to the step labeled cue loop."), the cue should be discarded and the cue loop restarted if an "identifier" line is followed by an empty line. Transitioning to the 'BadCue' state will lose the transition, so we need to transition explicitly from the 'TimingsAndSettings' state (to the 'Id' state.) BUG=314056 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -0 lines) Patch
A LayoutTests/media/track/captions-webvtt/tc030-interspersed-non-cue.vtt View 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/media/track/track-webvtt-tc030-interspersed-non-cue.html View 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/media/track/track-webvtt-tc030-interspersed-non-cue-expected.txt View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/core/html/track/WebVTTParser.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fs
7 years, 1 month ago (2013-11-01 12:58:48 UTC) #1
Nate Chapin
lgtm
7 years, 1 month ago (2013-11-01 16:23:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/55853002/1
7 years, 1 month ago (2013-11-01 16:44:05 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-01 18:08:40 UTC) #4
Message was sent while issue was closed.
Change committed as 161184

Powered by Google App Engine
This is Rietveld 408576698