AudioNodeOutput::enable() and AudioNodeOutput::disable() should not be reentered

AudioNodeOutput::enable() and AudioNodeOutput::disable() should not be reentered

AudioNodeOutput::disable() can be reentered and causes the following crash.

ASSERTION FAILED: m_outputs.contains(&output)
../../third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp(98) : void blink::AudioNodeInput::disable(blink::AudioNodeOutput &)
Received signal 11 SEGV_MAPERR 0000fbadbeef

To avoid AudioNodeOutput::disable() from getting reentered, this CL moves the place
of flipping m_isEnabled.

The same issue is in AudioNodeOutput::enable() and this CL addresses the issue as well.

BUG=411989
TEST=None, it's hard to create a simple test html that reproduces the bug.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181693

[haraken, 2014-09-09 01:31:04]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org, rtoy@chromium.org

[haraken, 2014-09-09 01:31:05]

PTAL

[Mads Ager (chromium), 2014-09-09 08:07:02]

ager@chromium.org changed reviewers:
+ ager@chromium.org

[Mads Ager (chromium), 2014-09-09 08:07:02]

LGTM, but Raymond should verify. :)

[Raymond Toy, 2014-09-09 16:17:04]

LGTM too.

Do you think there is a similar problem in AudioNodeOutput::disable and
AudioNodeOutput::enable? Should m_isEnabled = false there be moved up as well?

[haraken, 2014-09-10 01:03:50]

The CQ bit was checked by haraken@chromium.org

[haraken, 2014-09-10 01:04:41]

> Do you think there is a similar problem in AudioNodeOutput::disable and
> AudioNodeOutput::enable? Should m_isEnabled = false there be moved up as well?

Sorry, it's just that the CL description was wrong. This CL exactly handles the
issue of AudioNodeOutput::disable and AudioNodeOutput::enable.

[commit-bot: I haz the power, 2014-09-10 01:04:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/558523002/1

[haraken, 2014-09-10 01:05:13]

The CQ bit was unchecked by haraken@chromium.org

[haraken, 2014-09-10 01:05:16]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2014-09-10 01:05:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/haraken@chromium.org/558523002/1

[commit-bot: I haz the power, 2014-09-10 02:04:42]

Committed patchset #1 (id:1) as 181693