Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 558513002: Don't try to access a NULL plugin element or document in PepperPluginInstanceImpl (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't try to access a NULL plugin element or document in PepperPluginInstanceImpl There appear to be cases where the WebElement or Document associated with a plugin have been destroyed but the PepperPluginInstance isn't yet destroyed and there is some attempt to script into the plugin which tries to access the plugin context. In these case we should just return an empty handle to the context. TBR=dmichael@chromium.org BUG=411778 Committed: https://crrev.com/41d1beae12ad4f9ea055aea40fee8238490db07e Cr-Commit-Position: refs/heads/master@{#293873}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
raymes
6 years, 3 months ago (2014-09-08 23:37:15 UTC) #2
raymes
6 years, 3 months ago (2014-09-08 23:37:51 UTC) #4
Sam McNally
lgtm
6 years, 3 months ago (2014-09-08 23:47:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/558513002/20001
6 years, 3 months ago (2014-09-08 23:50:51 UTC) #7
dmichael (off chromium)
lgtm
6 years, 3 months ago (2014-09-09 00:04:09 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 72a60f5e9435d0b56393cdbf0c3092ca6252b93c
6 years, 3 months ago (2014-09-09 06:34:08 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/41d1beae12ad4f9ea055aea40fee8238490db07e
Cr-Commit-Position: refs/heads/master@{#293873}

Powered by Google App Engine
This is Rietveld 408576698