Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 558503006: ExcServerVariants test: don’t test debug thread state flavors (Closed)

Created:
6 years, 3 months ago by Mark Mentovai
Modified:
6 years, 3 months ago
Reviewers:
Robert Sesek
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Project:
crashpad
Visibility:
Public.

Description

ExcServerVariants test: don’t test debug thread state flavors. Kernel bugs prevent debug thread state flavors from being delivered to exception handlers properly. Through luck, things work out for x86_DEBUG_STATE and x86_DEBUG_STATE64, but a handler registered to receive the x86_DEBUG_STATE32 thread state flavor will never be called. For the x86 family, the only thread state flavors that can be delivered to exception handlers are the thread, float, and exception flavors. Radar 18312067 is filed. TEST=util_test ExcServerVariants.ThreadStates R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/1990a6ca2a447a03dce2a4e15f910889097e427f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M util/mach/exc_server_variants_test.cc View 1 chunk +24 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years, 3 months ago (2014-09-11 22:14:06 UTC) #2
Robert Sesek
LGTM
6 years, 3 months ago (2014-09-12 14:37:56 UTC) #3
Mark Mentovai
6 years, 3 months ago (2014-09-12 16:14:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 1990a6c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698