Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 558503005: Disable XI2 events on mirror window (Closed)

Created:
6 years, 3 months ago by kpschoedel
Modified:
6 years, 3 months ago
Reviewers:
oshima, sadrul
CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable XI2 events on mirror window BUG=406064 Committed: https://crrev.com/8417c8e514f88b0f431ed8c4d7e64f27faaffdab Cr-Commit-Position: refs/heads/master@{#294477}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review feedback (oshima). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ash/display/mirror_window_controller.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
kpschoedel
6 years, 3 months ago (2014-09-11 17:19:48 UTC) #2
oshima
+sadrul lgtm if sadrul approved.
6 years, 3 months ago (2014-09-11 17:30:29 UTC) #4
oshima
https://codereview.chromium.org/558503005/diff/1/ash/display/mirror_window_controller.cc File ash/display/mirror_window_controller.cc (right): https://codereview.chromium.org/558503005/diff/1/ash/display/mirror_window_controller.cc#newcode50 ash/display/mirror_window_controller.cc:50: memset(mask, 0, sizeof(mask)); nit: unsigned char mask[..] = {0}
6 years, 3 months ago (2014-09-11 17:33:55 UTC) #5
kpschoedel
https://codereview.chromium.org/558503005/diff/1/ash/display/mirror_window_controller.cc File ash/display/mirror_window_controller.cc (right): https://codereview.chromium.org/558503005/diff/1/ash/display/mirror_window_controller.cc#newcode50 ash/display/mirror_window_controller.cc:50: memset(mask, 0, sizeof(mask)); On 2014/09/11 17:33:55, oshima wrote: > ...
6 years, 3 months ago (2014-09-11 17:49:19 UTC) #6
sadrul
LGTM What would be the fix for ozone (i.e. non-x11)? Can you file a bug ...
6 years, 3 months ago (2014-09-11 19:33:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558503005/20001
6 years, 3 months ago (2014-09-11 19:56:04 UTC) #9
kpschoedel
On 2014/09/11 19:33:14, sadrul wrote: > What would be the fix for ozone (i.e. non-x11)? ...
6 years, 3 months ago (2014-09-11 20:10:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as d61231318166745ac78c1df55359de9481971945
6 years, 3 months ago (2014-09-11 22:20:50 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 22:31:05 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8417c8e514f88b0f431ed8c4d7e64f27faaffdab
Cr-Commit-Position: refs/heads/master@{#294477}

Powered by Google App Engine
This is Rietveld 408576698