Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 558483003: Rename athena/common to athena/util (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
Reviewers:
danakj, sadrul
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename athena/common to athena/util "common" is used for the code that is common better renderer and browser. Rename to "util" instead. BUG=None TBR=danakj@chromium.org Committed: https://crrev.com/6f4aaa635947f11cf1a9edf9f4221290fa9af2a6 Cr-Commit-Position: refs/heads/master@{#294025}

Patch Set 1 #

Patch Set 2 : revert unnecessary change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -207 lines) Patch
M athena/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/athena.gyp View 2 chunks +6 lines, -6 lines 0 comments Download
D athena/common/DEPS View 1 chunk +0 lines, -5 lines 0 comments Download
D athena/common/container_priorities.h View 1 chunk +0 lines, -20 lines 0 comments Download
D athena/common/fill_layout_manager.h View 1 chunk +0 lines, -36 lines 0 comments Download
D athena/common/fill_layout_manager.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D athena/common/fill_layout_manager_unittest.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D athena/common/switches.h View 1 chunk +0 lines, -16 lines 0 comments Download
D athena/common/switches.cc View 1 chunk +0 lines, -22 lines 0 comments Download
M athena/env/athena_env_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/home/home_card_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M athena/input/accelerator_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/screen/screen_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/screen/screen_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/system/system_ui_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + athena/util/DEPS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + athena/util/container_priorities.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + athena/util/fill_layout_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + athena/util/fill_layout_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
A + athena/util/fill_layout_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + athena/util/switches.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + athena/util/switches.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/virtual_keyboard/virtual_keyboard_manager_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/wm/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/window_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (5 generated)
oshima
6 years, 3 months ago (2014-09-08 22:28:25 UTC) #2
sadrul
rslgtm
6 years, 3 months ago (2014-09-09 14:29:22 UTC) #3
oshima
removed unnecessary change in extensions/ (not sure how this happened. maybe a bug in mass-rename.py) ...
6 years, 3 months ago (2014-09-09 19:34:22 UTC) #4
oshima
On 2014/09/09 19:34:22, oshima wrote: > removed unnecessary change in extensions/ (not sure how this ...
6 years, 3 months ago (2014-09-09 20:21:26 UTC) #5
sadrul
Oh, whoops. LGTM, then :)
6 years, 3 months ago (2014-09-09 20:22:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/558483003/20001
6 years, 3 months ago (2014-09-09 20:35:06 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9757)
6 years, 3 months ago (2014-09-09 21:37:47 UTC) #10
oshima
tbr'ing danakj@ for moving DEPS file containing ui/compositor
6 years, 3 months ago (2014-09-09 22:10:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/558483003/20001
6 years, 3 months ago (2014-09-09 22:13:11 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001) as b03745ac7c226d29910bb8ca1e01060a7067aea7
6 years, 3 months ago (2014-09-09 22:59:17 UTC) #15
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:12 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6f4aaa635947f11cf1a9edf9f4221290fa9af2a6
Cr-Commit-Position: refs/heads/master@{#294025}

Powered by Google App Engine
This is Rietveld 408576698