Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 558473002: Remove some CSS properties from UseCounters (Closed)

Created:
6 years, 3 months ago by rwlbuis
Modified:
6 years, 3 months ago
Reviewers:
Mike West
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove some CSS properties from UseCounters All of these measure stable features except CSSPropertyWebkitCursorVisibility which is actually removed. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181680

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M Source/core/frame/UseCounter.cpp View 3 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
rwlbuis
PTAL
6 years, 3 months ago (2014-09-09 14:20:21 UTC) #2
Mike West
lgtm
6 years, 3 months ago (2014-09-09 18:31:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/558473002/1
6 years, 3 months ago (2014-09-09 18:32:58 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26275)
6 years, 3 months ago (2014-09-09 20:57:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/558473002/1
6 years, 3 months ago (2014-09-09 21:31:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181680
6 years, 3 months ago (2014-09-09 22:20:34 UTC) #10
masataka
Why commenting them out? That will make tracking their usage on chromestatus.com impossible. (e.g. http://www.chromestatus.com/metrics/css/popularity#webkit-box-decoration-break ...
6 years, 3 months ago (2014-09-10 00:00:01 UTC) #11
Timothy Loh
On 2014/09/10 00:00:01, myakura wrote: > Why commenting them out? That will make tracking their ...
6 years, 3 months ago (2014-09-10 12:41:25 UTC) #12
Mike West
On 2014/09/10 12:41:25, Timothy Loh wrote: > On 2014/09/10 00:00:01, myakura wrote: > > Why ...
6 years, 3 months ago (2014-09-10 14:08:02 UTC) #13
Mike West
On 2014/09/10 14:08:02, Mike West wrote: > On 2014/09/10 12:41:25, Timothy Loh wrote: > > ...
6 years, 3 months ago (2014-09-10 14:13:26 UTC) #14
Mike West
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/559073002/ by mkwst@chromium.org. ...
6 years, 3 months ago (2014-09-10 14:13:40 UTC) #15
rwlbuis
6 years, 3 months ago (2014-09-10 14:54:51 UTC) #16
Message was sent while issue was closed.
On 2014/09/10 14:13:26, Mike West wrote:
> On 2014/09/10 14:08:02, Mike West wrote:
> > On 2014/09/10 12:41:25, Timothy Loh wrote:
> > > On 2014/09/10 00:00:01, myakura wrote:
> > > > Why commenting them out? That will make tracking their usage on
> > > http://chromestatus.com
> > > > impossible. (e.g. 
> > > >
> >
http://www.chromestatus.com/metrics/css/popularity#webkit-box-decoration-break
> > > )
> > > 
> > > Yeah this seems odd, properties that still exist shouldn't be commented
out
> > > here.
> > 
> > Hrm. I assumed this wouldn't compile if they were still in use. Is that not
> the
> > case?
> 
> Nope. I'm an idiot. I misunderstood the CL, my apologies.
> 
> rwlbuis@: We don't want to remove properties that we still support.
Maintaining
> the UseCounter data helps us understand property use in the wild, which is
> useful in guiding both future work and future deprecations. I'm going to
revert
> this patch. If you'd like to upload a separate patch which removes the
> CSSPropertyWebkitCursorVisibility enum (which it looks like we've actually
> removed support for), I'll happily LGTM it. Sorry for my initial misreading of
> the patch. :(

Oops! Ok I'll make that patch.

Powered by Google App Engine
This is Rietveld 408576698