|
|
DescriptionRemove some CSS properties from UseCounters
All of these measure stable features except CSSPropertyWebkitCursorVisibility which
is actually removed.
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181680
Patch Set 1 #
Messages
Total messages: 16 (4 generated)
rob.buis@samsung.com changed reviewers: + mkwst@chromium.org
PTAL
The CQ bit was checked by mkwst@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/558473002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26275)
The CQ bit was checked by rob.buis@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/558473002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181680
Message was sent while issue was closed.
Why commenting them out? That will make tracking their usage on chromestatus.com impossible. (e.g. http://www.chromestatus.com/metrics/css/popularity#webkit-box-decoration-break )
Message was sent while issue was closed.
On 2014/09/10 00:00:01, myakura wrote: > Why commenting them out? That will make tracking their usage on http://chromestatus.com > impossible. (e.g. > http://www.chromestatus.com/metrics/css/popularity#webkit-box-decoration-break ) Yeah this seems odd, properties that still exist shouldn't be commented out here.
Message was sent while issue was closed.
On 2014/09/10 12:41:25, Timothy Loh wrote: > On 2014/09/10 00:00:01, myakura wrote: > > Why commenting them out? That will make tracking their usage on > http://chromestatus.com > > impossible. (e.g. > > http://www.chromestatus.com/metrics/css/popularity#webkit-box-decoration-break > ) > > Yeah this seems odd, properties that still exist shouldn't be commented out > here. Hrm. I assumed this wouldn't compile if they were still in use. Is that not the case?
Message was sent while issue was closed.
On 2014/09/10 14:08:02, Mike West wrote: > On 2014/09/10 12:41:25, Timothy Loh wrote: > > On 2014/09/10 00:00:01, myakura wrote: > > > Why commenting them out? That will make tracking their usage on > > http://chromestatus.com > > > impossible. (e.g. > > > > http://www.chromestatus.com/metrics/css/popularity#webkit-box-decoration-break > > ) > > > > Yeah this seems odd, properties that still exist shouldn't be commented out > > here. > > Hrm. I assumed this wouldn't compile if they were still in use. Is that not the > case? Nope. I'm an idiot. I misunderstood the CL, my apologies. rwlbuis@: We don't want to remove properties that we still support. Maintaining the UseCounter data helps us understand property use in the wild, which is useful in guiding both future work and future deprecations. I'm going to revert this patch. If you'd like to upload a separate patch which removes the CSSPropertyWebkitCursorVisibility enum (which it looks like we've actually removed support for), I'll happily LGTM it. Sorry for my initial misreading of the patch. :(
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/559073002/ by mkwst@chromium.org. The reason for reverting is: We don't want to remove properties that we still support..
Message was sent while issue was closed.
On 2014/09/10 14:13:26, Mike West wrote: > On 2014/09/10 14:08:02, Mike West wrote: > > On 2014/09/10 12:41:25, Timothy Loh wrote: > > > On 2014/09/10 00:00:01, myakura wrote: > > > > Why commenting them out? That will make tracking their usage on > > > http://chromestatus.com > > > > impossible. (e.g. > > > > > > http://www.chromestatus.com/metrics/css/popularity#webkit-box-decoration-break > > > ) > > > > > > Yeah this seems odd, properties that still exist shouldn't be commented out > > > here. > > > > Hrm. I assumed this wouldn't compile if they were still in use. Is that not > the > > case? > > Nope. I'm an idiot. I misunderstood the CL, my apologies. > > rwlbuis@: We don't want to remove properties that we still support. Maintaining > the UseCounter data helps us understand property use in the wild, which is > useful in guiding both future work and future deprecations. I'm going to revert > this patch. If you'd like to upload a separate patch which removes the > CSSPropertyWebkitCursorVisibility enum (which it looks like we've actually > removed support for), I'll happily LGTM it. Sorry for my initial misreading of > the patch. :( Oops! Ok I'll make that patch. |