Add chrome.usb.getConfiguration and expose extra descriptors.

Add chrome.usb.getConfiguration and expose extra descriptors.

Adds a new API function, chrome.usb.getConfiguration, that returns all
the data from the device's configuration descriptor instead of just the
interfaces as chrome.usb.listInterfaces does. Each level of the
descriptor hierarchy also gets an "extra_data" field which contains all
of the miscellaneous descriptors assocated with a configuration,
interface or endpoint.

BUG=382908
Committed: https://crrev.com/79146d0b0d917eb6482cf2c22ec76db09eaa5a37
Cr-Commit-Position: refs/heads/master@{#294758}

[Reilly Grant (use Gerrit), 2014-09-11 01:21:35]

reillyg@chromium.org changed reviewers:
+ rpaquay@chromium.org

[Reilly Grant (use Gerrit), 2014-09-11 05:59:22]

Patchset #1 (id:1) has been deleted

[Reilly Grant (use Gerrit), 2014-09-11 06:05:43]

Patchset #1 (id:20001) has been deleted

[Reilly Grant (use Gerrit), 2014-09-11 06:21:40]

Patchset #1 (id:40001) has been deleted

[Reilly Grant (use Gerrit), 2014-09-11 15:25:46]

Patchset #1 (id:60001) has been deleted

[rpaquay, 2014-09-11 19:09:23]

lgtm

[Reilly Grant (use Gerrit), 2014-09-11 19:09:30]

reillyg@chromium.org changed reviewers:
+ meacer@chromium.org

[Reilly Grant (use Gerrit), 2014-09-11 19:11:01]

Adding Mustafa for security review since this is exposing a little more
information about the device than we were before. I don't believe it is an issue
because this is not a new category of information, just missing fields that are
necessary to support some devices.

[meacer, 2014-09-11 19:17:20]

Thanks for looping me in Reilly. Just to confirm, this API will only be
available if the app can already use findDevices API, right (ie. it needs to
have "usb" permission).

If so, lgtm.

https://codereview.chromium.org/558373002/diff/80001/extensions/browser/api/u...
File extensions/browser/api/usb/usb_api.cc (right):

https://codereview.chromium.org/558373002/diff/80001/extensions/browser/api/u...
extensions/browser/api/usb/usb_api.cc:386: for (size_t i = 0; i <
input.endpoints.size(); ++i) {
nit: Why not this?

for (input::iterator it = input.endpoints.begin();
     it != input.endpoints.end();
     ++it)

https://codereview.chromium.org/558373002/diff/80001/extensions/browser/api/u...
extensions/browser/api/usb/usb_api.cc:402: for (size_t i = 0; i <
input.interfaces.size(); ++i) {
Same as above

[Reilly Grant (use Gerrit), 2014-09-11 19:38:47]

https://codereview.chromium.org/558373002/diff/80001/extensions/browser/api/u...
File extensions/browser/api/usb/usb_api.cc (right):

https://codereview.chromium.org/558373002/diff/80001/extensions/browser/api/u...
extensions/browser/api/usb/usb_api.cc:386: for (size_t i = 0; i <
input.endpoints.size(); ++i) {
On 2014/09/11 19:17:20, Mustafa Emre Acer wrote:
> nit: Why not this?
> 
> for (input::iterator it = input.endpoints.begin();
>      it != input.endpoints.end();
>      ++it)

That's not valid C++ but I wish it were. I'm going to add typedefs for
InterfaceIterator and EndpointIterator to usb_descriptors.h for this purpose.

[meacer, 2014-09-11 19:55:05]

https://codereview.chromium.org/558373002/diff/80001/extensions/browser/api/u...
File extensions/browser/api/usb/usb_api.cc (right):

https://codereview.chromium.org/558373002/diff/80001/extensions/browser/api/u...
extensions/browser/api/usb/usb_api.cc:386: for (size_t i = 0; i <
input.endpoints.size(); ++i) {
On 2014/09/11 19:38:47, reillyg wrote:
> On 2014/09/11 19:17:20, Mustafa Emre Acer wrote:
> > nit: Why not this?
> > 
> > for (input::iterator it = input.endpoints.begin();
> >      it != input.endpoints.end();
> >      ++it)
> 
> That's not valid C++ but I wish it were. I'm going to add typedefs for
> InterfaceIterator and EndpointIterator to usb_descriptors.h for this purpose.

Yes, fail on my part. I meant |EndpointIterator it|.

[Reilly Grant (use Gerrit), 2014-09-11 20:44:29]

Rebased this patch on top of https://codereview.chromium.org/562763002/ where I
have added interface and endpoint iterators.

[Reilly Grant (use Gerrit), 2014-09-12 15:56:58]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-09-12 15:58:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/558373002/100001

[Reilly Grant (use Gerrit), 2014-09-12 16:08:59]

The CQ bit was unchecked by reillyg@chromium.org

[Reilly Grant (use Gerrit), 2014-09-12 16:29:11]

reillyg@chromium.org changed reviewers:
+ asvitkine@chromium.org, scheib@chromium.org

[Reilly Grant (use Gerrit), 2014-09-12 16:30:26]

Added scheib@ for extension/common/api/usb.idl changes.

Added asvitkine@ for extension function histogram changes.

[Alexei Svitkine (slow), 2014-09-12 16:43:47]

lgtm

[scheib, 2014-09-12 19:19:07]

extension/common/api/usb.idl lgtm.

[Reilly Grant (use Gerrit), 2014-09-13 06:52:24]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-09-13 06:53:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/558373002/120001

[commit-bot: I haz the power, 2014-09-13 06:57:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-13 06:57:26]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Reilly Grant (use Gerrit), 2014-09-13 17:05:39]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-09-13 17:06:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/558373002/140001

[commit-bot: I haz the power, 2014-09-13 18:43:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-13 18:43:48]

Try jobs failed on following builders:
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Reilly Grant (use Gerrit), 2014-09-14 01:30:06]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2014-09-14 01:30:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/558373002/140001

[commit-bot: I haz the power, 2014-09-14 05:21:49]

Committed patchset #4 (id:140001) as 2532566fa1fd111bf006a5d2943cd19b599d023e

[commit-bot: I haz the power, 2014-09-14 05:23:33]

Patchset 4 (id:??) landed as
https://crrev.com/79146d0b0d917eb6482cf2c22ec76db09eaa5a37
Cr-Commit-Position: refs/heads/master@{#294758}