Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 558363002: Fix tests (Closed)

Created:
6 years, 3 months ago by michaelpg
Modified:
6 years, 3 months ago
CC:
ojan, blink-reviews, cbiesinger, dsinclair, jochen (gone - plz use gerrit), leviw_travelin_and_unemployed, szager1, teravest
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M Tools/GardeningServer/test/run-unit-tests.html View 1 chunk +2 lines, -1 line 0 comments Download
M Tools/GardeningServer/test/unit-tests.html View 1 chunk +1 line, -0 lines 1 comment Download
M Tools/GardeningServer/ui/ct-unexpected-failures.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
michaelpg
85% pass rate to 100% in 3 lines or less :-)
6 years, 3 months ago (2014-09-11 00:32:31 UTC) #1
leviw_travelin_and_unemployed
LGTM.
6 years, 3 months ago (2014-09-11 01:04:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558363002/1
6 years, 3 months ago (2014-09-11 01:13:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181776
6 years, 3 months ago (2014-09-11 01:14:32 UTC) #6
ojan
https://codereview.chromium.org/558363002/diff/1/Tools/GardeningServer/test/unit-tests.html File Tools/GardeningServer/test/unit-tests.html (right): https://codereview.chromium.org/558363002/diff/1/Tools/GardeningServer/test/unit-tests.html#newcode10 Tools/GardeningServer/test/unit-tests.html:10: <link rel="import" href="../lib/test/update-util-tests.html"> We really need to find a ...
6 years, 3 months ago (2014-09-11 01:51:08 UTC) #8
michaelpg
6 years, 3 months ago (2014-09-11 02:50:17 UTC) #9
Message was sent while issue was closed.
On 2014/09/11 01:51:08, ojan-only-code-yellow-reviews wrote:
>
https://codereview.chromium.org/558363002/diff/1/Tools/GardeningServer/test/u...
> File Tools/GardeningServer/test/unit-tests.html (right):
> 
>
https://codereview.chromium.org/558363002/diff/1/Tools/GardeningServer/test/u...
> Tools/GardeningServer/test/unit-tests.html:10: <link rel="import"
> href="../lib/test/update-util-tests.html">
> We really need to find a better solution to this. Maybe we should just add a
> presubmit that checks that every -tests file is listed in this one?

I was thinking along the same lines. The file should just be regenerated
automatically by the presubmit script.

Powered by Google App Engine
This is Rietveld 408576698