Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 558343004: Compositor bindings for mojo html_viewer (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@mojo_view_manager_surface
Project:
chromium
Visibility:
Public.

Description

Compositor bindings for mojo html_viewer This binds mojo's html_viewer to a compositor implementation that uses surfaces to present. It reuses the bindings for the WebLayer* types in cc/blink and adds a new implementation of blink::WebLayerTreeView that shares some things with content/renderer/gpu/render_widget_compositor.cc but is distinct enough to be its own class. Whenever the compositor resizes (and thus needs a new surface id) it passes the surface id to the view manager client lib. This also adds mojo bindings for a few new quad types that are used on the web. We don't yet have support for video quad types, but we don't have the media system hooked up to html_viewer yet either so these will not be generated. Committed: https://crrev.com/2abb46fdc18d2110b443a9e570ea393e3b0a42c5 Cr-Commit-Position: refs/heads/master@{#294546} Committed: https://crrev.com/40cf556f0992839dbf4de2bfba1d4d96ed12bb8c Cr-Commit-Position: refs/heads/master@{#294613}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : Add missing m/s/p/cpp/v_m -> m/s/p/cpp/surfaces dep in GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+639 lines, -73 lines) Patch
M mojo/cc/output_surface_mojo.h View 1 2 3 2 chunks +13 lines, -2 lines 0 comments Download
M mojo/cc/output_surface_mojo.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 3 chunks +8 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.h View 3 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/blink_platform_impl.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 5 chunks +11 lines, -5 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 1 8 chunks +26 lines, -38 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 3 chunks +25 lines, -11 lines 0 comments Download
A mojo/services/html_viewer/weblayertreeview_impl.h View 1 1 chunk +132 lines, -0 lines 0 comments Download
A mojo/services/html_viewer/weblayertreeview_impl.cc View 1 1 chunk +232 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/geometry/geometry_type_converters.h View 1 chunk +9 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/geometry/lib/geometry_type_converters.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc View 1 2 8 chunks +82 lines, -2 lines 0 comments Download
M mojo/services/public/cpp/surfaces/surfaces_type_converters.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M mojo/services/public/interfaces/geometry/geometry.mojom View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/quads.mojom View 1 6 chunks +46 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jamesr
6 years, 3 months ago (2014-09-11 19:40:56 UTC) #2
sky
LGTM https://codereview.chromium.org/558343004/diff/30018/mojo/cc/output_surface_mojo.h File mojo/cc/output_surface_mojo.h (right): https://codereview.chromium.org/558343004/diff/30018/mojo/cc/output_surface_mojo.h#newcode17 mojo/cc/output_surface_mojo.h:17: virtual ~OutputSurfaceMojoClient() {} nit: make protected so ownership ...
6 years, 3 months ago (2014-09-11 19:56:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558343004/50001
6 years, 3 months ago (2014-09-12 04:50:16 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:50001) as bc1936df8397699551c8b31a9cc965bc2f14d5b8
6 years, 3 months ago (2014-09-12 05:50:06 UTC) #6
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/2abb46fdc18d2110b443a9e570ea393e3b0a42c5 Cr-Commit-Position: refs/heads/master@{#294546}
6 years, 3 months ago (2014-09-12 05:52:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558343004/70001
6 years, 3 months ago (2014-09-12 16:49:00 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:70001) as 52014a7fdfde3ccc52a18b0a492033cb404f1230
6 years, 3 months ago (2014-09-12 18:09:37 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 18:30:05 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/40cf556f0992839dbf4de2bfba1d4d96ed12bb8c
Cr-Commit-Position: refs/heads/master@{#294613}

Powered by Google App Engine
This is Rietveld 408576698