GN: More CrOS fixes

GN: More CrOS fixes

OS_CHROMEOS is defined in //build/config/linux:sdk per brettw
recommendation.

Typo fixed in ui/ozone/BUILD.gn

Some source-list fixes in content/browser/BUILD.gn that take both
use_x11 and use_ozone into account.

BUG=None
TEST=None

Committed: https://crrev.com/db5203ee72bc04974fde7bc990a76e9ca6449f6f
Cr-Commit-Position: refs/heads/master@{#294426}

[Chris Masone, 2014-09-10 22:36:31]

cmasone@chromium.org changed reviewers:
+ mukai@chromium.org

[Chris Masone, 2014-09-10 22:37:45]

On 2014/09/10 22:36:31, Chris Masone wrote:
> mailto:cmasone@chromium.org changed reviewers:
> + mailto:mukai@chromium.org

Hi, Jun. I believe these changes cover a few use_ozone cases as well as use_x11.
I figure you can integrate them into your ongoing patch-set if you'd like

[Jun Mukai, 2014-09-10 23:15:56]

lgtm

[Chris Masone, 2014-09-11 00:03:42]

The CQ bit was checked by cmasone@chromium.org

[commit-bot: I haz the power, 2014-09-11 00:06:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/558343002/1

[commit-bot: I haz the power, 2014-09-11 00:18:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 00:18:47]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/54381)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/59323)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Chris Masone, 2014-09-11 02:07:42]

cmasone@chromium.org changed reviewers:
+ brettw@chromium.org

[Chris Masone, 2014-09-11 02:46:38]

Brett, can I get an OWNERs LGTM?

[spang, 2014-09-11 14:39:10]

spang@chromium.org changed reviewers:
+ spang@chromium.org

[spang, 2014-09-11 14:39:11]

lgtm

[brettw, 2014-09-11 17:13:44]

lgtm

https://codereview.chromium.org/558343002/diff/20001/content/browser/BUILD.gn
File content/browser/BUILD.gn (right):

https://codereview.chromium.org/558343002/diff/20001/content/browser/BUILD.gn...
content/browser/BUILD.gn:267: if (is_chromeos || !use_ozone) {
I think this would be more clear with one if for the chromeos:
  if (is_chromeos) {
    if (!use_ozone) {
      sources -= ...
    }
    if (!use_x11)
    ...
  }

[Chris Masone, 2014-09-11 17:16:17]

https://codereview.chromium.org/558343002/diff/20001/content/browser/BUILD.gn
File content/browser/BUILD.gn (right):

https://codereview.chromium.org/558343002/diff/20001/content/browser/BUILD.gn...
content/browser/BUILD.gn:267: if (is_chromeos || !use_ozone) {
On 2014/09/11 17:13:44, brettw wrote:
> I think this would be more clear with one if for the chromeos:
>   if (is_chromeos) {
>     if (!use_ozone) {
>       sources -= ...
>     }
>     if (!use_x11)
>     ...
>   }

That would change the semantics, though. If I did that, a Linux X11 build would
still have power_save_blocker_ozone.cc in the sources list, which would be
incorrect.

[Chris Masone, 2014-09-11 17:16:20]

The CQ bit was checked by cmasone@chromium.org

[commit-bot: I haz the power, 2014-09-11 17:25:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/558343002/20001

[brettw, 2014-09-11 17:35:48]

https://codereview.chromium.org/558343002/diff/20001/content/browser/BUILD.gn
File content/browser/BUILD.gn (right):

https://codereview.chromium.org/558343002/diff/20001/content/browser/BUILD.gn...
content/browser/BUILD.gn:267: if (is_chromeos || !use_ozone) {
Oh, right.

[commit-bot: I haz the power, 2014-09-11 18:19:36]

Committed patchset #2 (id:20001) as 9795dc95b5dff65d01727261da3dd93192f3e36c

[commit-bot: I haz the power, 2014-09-11 18:43:24]

Patchset 2 (id:??) landed as
https://crrev.com/db5203ee72bc04974fde7bc990a76e9ca6449f6f
Cr-Commit-Position: refs/heads/master@{#294426}