Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558333003: DevTools: Add a test on a crash fix in ScriptDebugServer::wrapCallFrames. (Closed)

Created:
6 years, 3 months ago by aandrey
Modified:
6 years, 3 months ago
Reviewers:
yangguo, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Add a test on a crash fix in ScriptDebugServer::wrapCallFrames. This was fixed in V8 in r23858. BUG=411196 TBR=loislo, yangguo Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181920

Patch Set 1 #

Patch Set 2 : tweaked the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -0 lines) Patch
A LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash.html View 1 1 chunk +72 lines, -0 lines 0 comments Download
A LayoutTests/inspector/sources/debugger/rethrow-error-from-bindings-crash-expected.txt View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
aandrey
6 years, 3 months ago (2014-09-12 15:27:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558333003/1
6 years, 3 months ago (2014-09-12 15:30:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558333003/20001
6 years, 3 months ago (2014-09-12 16:51:48 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 17:56:50 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 181920

Powered by Google App Engine
This is Rietveld 408576698