Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 558283003: avoid ambiguous overload for operator= in FrameView.h (Closed)

Created:
6 years, 3 months ago by Mostyn Bramley-Moore
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Avoid ambiguous overload for operator= in FrameView.h Followup to CL 459633002, this fixes a compile error with some older toolchains. BUG=401254 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181772

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Mostyn Bramley-Moore
@rune, eseidel: does this tiny fixup look OK?
6 years, 3 months ago (2014-09-10 21:52:32 UTC) #2
rune
LGTM Before landing, in the description change avoid -> Avoid and just drop the IMO.
6 years, 3 months ago (2014-09-10 22:16:56 UTC) #3
Mostyn Bramley-Moore
Done.
6 years, 3 months ago (2014-09-10 22:19:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/558283003/1
6 years, 3 months ago (2014-09-10 22:20:03 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 23:22:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181772

Powered by Google App Engine
This is Rietveld 408576698