Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 558283002: Fix bump-scroll. (Closed)

Created:
6 years, 3 months ago by Jamie
Modified:
6 years ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix bump-scroll. Apply bump scroll to the entire client-plugin-render hierarchy, not just the plugin, which doesn't handle rendering when MediaSource is enabled. BUG=411996 Committed: https://crrev.com/73dafe3a8b7084b33fb93aefb1588056e076775f Cr-Commit-Position: refs/heads/master@{#294267}

Patch Set 1 #

Patch Set 2 : Fix another instance. #

Total comments: 2

Patch Set 3 : Reviewer feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M remoting/webapp/client_session.js View 1 2 4 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie
ptal
6 years, 3 months ago (2014-09-10 18:25:04 UTC) #2
Sergey Ulanov
lgtm https://codereview.chromium.org/558283002/diff/20001/remoting/webapp/client_session.js File remoting/webapp/client_session.js (right): https://codereview.chromium.org/558283002/diff/20001/remoting/webapp/client_session.js#newcode1334 remoting/webapp/client_session.js:1334: var style = this.container_.style; nit: move these below ...
6 years, 3 months ago (2014-09-10 22:07:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558283002/40001
6 years, 3 months ago (2014-09-10 22:51:20 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 7bd44206709ff1c514f36554f7e09ce38fab41d0
6 years, 3 months ago (2014-09-11 00:03:56 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 00:09:16 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/73dafe3a8b7084b33fb93aefb1588056e076775f
Cr-Commit-Position: refs/heads/master@{#294267}

Powered by Google App Engine
This is Rietveld 408576698