Issue 558273002: [NOT FOR REVIEW] easy-signin: Simple click to sign-in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 558273002: [NOT FOR REVIEW] easy-signin: Simple click to sign-in. (Closed)

Created:
6 years, 3 months ago by xiyuan

Modified:
6 years, 2 months ago

Reviewers:
Tim Song, tbarzic

CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@easy-signin-data

Project:
chromium

Visibility:
Public.

More Reviews

Description

easy-signin: Simple click to sign-in. - SetAuthType to USER_CLICK for paired user; - Sign in user on click; - Fix key removal failure due to lost authorization after key creation; BUG=

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+142 lines, -25 lines)			Patch
M	chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc	View	1	2 chunks	+10 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/easy_unlock/easy_unlock_key_manager.cc	View	1	3 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h	View		2 chunks	+17 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc	View	1	5 chunks	+105 lines, -16 lines	0 comments	Download
M	chromeos/login/auth/user_context.h	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

xiyuan

6 years, 3 months ago (2014-09-18 00:21:59 UTC) #2

Ignore the key manager change. I will split that part into a separate CL.

The last three files shows how to wire with existing login stack.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages