Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 558253003: display: Move ui/display/types/chromeos/* to ui/display/types/* (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
Reviewers:
Daniel Erat, oshima
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, ozone-reviews_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

display: Move ui/display/types/chromeos/* to ui/display/types/* Having these types disappear under chromeos=0 is a problem for platforms under ui/ozone, which also want to support embedded builds. There's no reason not to provide these everywhere. R=derat@chromium.org BUG=none TESt=build TBR=darin Committed: https://crrev.com/cef109772e3d82e5eca335ae9813d503e2809bfd Cr-Commit-Position: refs/heads/master@{#295468}

Patch Set 1 #

Patch Set 2 : also fix BUILD.gn #

Patch Set 3 : unsort X11 includes - they don't compile in sorted order #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -372 lines) Patch
M ash/display/display_change_observer_chromeos.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/display_change_observer_chromeos_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/display/projecting_observer_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/touch/touch_transformer_controller.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/power_button_controller.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M athena/env/athena_env_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/shell/browser/shell_desktop_controller.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/display/chromeos/display_configurator.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/display_configurator.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M ui/display/chromeos/display_configurator_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ui/display/chromeos/ozone/display_configurator_ozone.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/test/test_display_snapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/x11/display_mode_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/x11/display_snapshot_x11.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/display/chromeos/x11/native_display_delegate_x11.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/display/display.gyp View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M ui/display/types/BUILD.gn View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
D ui/display/types/chromeos/display_mode.h View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/display/types/chromeos/display_mode.cc View 1 chunk +0 lines, -28 lines 0 comments Download
D ui/display/types/chromeos/display_snapshot.h View 1 chunk +0 lines, -90 lines 0 comments Download
D ui/display/types/chromeos/display_snapshot.cc View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/display/types/chromeos/native_display_delegate.h View 1 chunk +0 lines, -95 lines 0 comments Download
D ui/display/types/chromeos/native_display_observer.h View 1 chunk +0 lines, -23 lines 0 comments Download
A + ui/display/types/display_mode.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/display/types/display_mode.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/display/types/display_snapshot.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/display/types/display_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/display/types/native_display_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/display/types/native_display_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/ozone/common/chromeos/display_mode_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/common/chromeos/display_snapshot_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/common/chromeos/display_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/common/chromeos/native_display_delegate_ozone.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/chromeos/display_message_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/chromeos/display_mode_dri.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/chromeos/display_snapshot_dri.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/chromeos/native_display_delegate_dri.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/chromeos/native_display_delegate_dri.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/chromeos/native_display_delegate_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/chromeos/native_display_delegate_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
spang
6 years, 3 months ago (2014-09-10 17:46:07 UTC) #1
spang
ping
6 years, 3 months ago (2014-09-12 16:18:26 UTC) #2
Daniel Erat
lgtm sorry, and thanks for the ping -- i missed this one.
6 years, 3 months ago (2014-09-12 16:22:48 UTC) #3
oshima
hi, can you hold this? I have a CL that needs to be merged back ...
6 years, 3 months ago (2014-09-15 19:41:48 UTC) #5
spang
On 2014/09/15 19:41:48, oshima wrote: > hi, can you hold this? I have a CL ...
6 years, 3 months ago (2014-09-15 19:42:20 UTC) #6
oshima
I actually changed the approach, so this shouldn't cause much conflict. Please go ahead and ...
6 years, 3 months ago (2014-09-17 00:06:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558253003/60001
6 years, 3 months ago (2014-09-18 00:57:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/11736)
6 years, 3 months ago (2014-09-18 01:08:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/558253003/60001
6 years, 3 months ago (2014-09-18 15:27:52 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as b3ae94b388ee48a814db20f17cb07b2cbd6601c8
6 years, 3 months ago (2014-09-18 15:47:18 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-18 15:47:51 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cef109772e3d82e5eca335ae9813d503e2809bfd
Cr-Commit-Position: refs/heads/master@{#295468}

Powered by Google App Engine
This is Rietveld 408576698