athena/content/shell/content_activity_factory.cc - Issue 558243002: V2 app support step2 : Use NativeAppWindow for Activity's window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/content/shell/content_activity_factory.cc

Issue 558243002: V2 app support step2 : Use NativeAppWindow for Activity's window. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/content/shell/content_activity_factory.cc

diff --git a/athena/content/shell/content_activity_factory.cc b/athena/content/shell/content_activity_factory.cc

index 03e637d1294dda16138c190450da48085d4b908e..d87c81e79c579294a4b93bb622d027086ad9135a 100644

--- a/athena/content/shell/content_activity_factory.cc

+++ b/athena/content/shell/content_activity_factory.cc

@@ -15,7 +15,8 @@ Activity* ContentActivityFactory::CreateAppActivity(

}

Activity* ContentActivityFactory::CreateAppActivity(

- extensions::AppWindow* app_window) {

+ extensions::AppWindow* app_window,

+ views::WebView* web_view) {

return NULL;

}

« no previous file with comments | « athena/content/content_activity_factory.h ('k') | athena/content/shell/shell_app_activity.h » ('j') | no next file with comments »