Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1396)

Issue 558163006: MIPS64: Fix move operations from coprocessor in simulator. (Closed)

Created:
6 years, 3 months ago by dusmil.imgtec
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS64: Fix move operations from coprocessor in simulator. This resolves calculation errors for trigonometric functions. TEST=test262/S15.8.2.7_A6.js BUG= R=jkummerow@chromium.org, paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=24013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -98 lines) Patch
M src/mips64/simulator-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/simulator-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 7 chunks +109 lines, -95 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dusmil.imgtec
6 years, 3 months ago (2014-09-17 10:44:10 UTC) #2
paul.l...
LGTM, but this also needs v8 team review, for the tests. (I will update the ...
6 years, 3 months ago (2014-09-17 14:17:14 UTC) #3
Jakob Kummerow
lgtm
6 years, 3 months ago (2014-09-17 16:14:11 UTC) #4
dusmil.imgtec
6 years, 3 months ago (2014-09-17 16:21:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24013 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698