Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 558163003: Update the user agent used in iOS 8. (Closed)

Created:
6 years, 3 months ago by lliabraa
Modified:
6 years, 3 months ago
CC:
chromium-reviews, huey
Project:
chromium
Visibility:
Public.

Description

Update the user agent used in iOS 8. BUG=391846 TEST=Go to whatsmyua.com on an iOS 8 device and verify that the AppleWebKit and Safari versions in the user agent are the same in MobileSafari and Chrome for iOS. Committed: https://crrev.com/918870fab73938563d008babb8fdcf4c6d88c975 Cr-Commit-Position: refs/heads/master@{#294168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ios/web/public/user_agent.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
lliabraa
6 years, 3 months ago (2014-09-10 13:06:22 UTC) #2
lliabraa
On 2014/09/10 13:06:22, lliabraa wrote: FYI - I posted a screenshot of whatsmyua.com in the ...
6 years, 3 months ago (2014-09-10 13:07:12 UTC) #3
stuartmorgan
Huh. Making the WebKit version go *down* is a bold choice. I wonder how many ...
6 years, 3 months ago (2014-09-10 13:15:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lliabraa@chromium.org/558163003/1
6 years, 3 months ago (2014-09-10 13:19:54 UTC) #6
rohitrao (ping after 24h)
+huey FYI I'm planning to leave this out of M37, unless someone objects strongly.
6 years, 3 months ago (2014-09-10 13:20:46 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8944f7cc6307c156320875e99525decb98e2e380
6 years, 3 months ago (2014-09-10 14:23:04 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 14:29:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/918870fab73938563d008babb8fdcf4c6d88c975
Cr-Commit-Position: refs/heads/master@{#294168}

Powered by Google App Engine
This is Rietveld 408576698