Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558163002: Add DOMPointInit (Closed)

Created:
6 years, 3 months ago by bashi
Modified:
6 years, 3 months ago
Reviewers:
haraken, zino
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, Inactive, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add DOMPointInit To remove generic Dictionary from a DOMPoint constructor. No changes in behavior; fast/dom/geometry-interfaces-dom-point.html should cover this change. Spec: http://dev.w3.org/fxtf/geometry/#DOMPoint BUG=403150 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181877

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -28 lines) Patch
M Source/core/core.gypi View 1 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/DOMPoint.h View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/dom/DOMPoint.cpp View 1 1 chunk +3 lines, -16 lines 0 comments Download
M Source/core/dom/DOMPoint.idl View 1 chunk +1 line, -10 lines 0 comments Download
A Source/core/dom/DOMPointInit.idl View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bashi
Haraken-san, could you take a look?
6 years, 3 months ago (2014-09-10 14:14:55 UTC) #2
haraken
+jinho LGTM. https://codereview.chromium.org/558163002/diff/1/Source/core/dom/DOMPointInit.idl File Source/core/dom/DOMPointInit.idl (right): https://codereview.chromium.org/558163002/diff/1/Source/core/dom/DOMPointInit.idl#newcode4 Source/core/dom/DOMPointInit.idl:4: Add a link to the spec.
6 years, 3 months ago (2014-09-10 15:37:40 UTC) #4
zino
lgtm
6 years, 3 months ago (2014-09-10 16:41:07 UTC) #5
bashi
Rebased (Pointers -> References) https://codereview.chromium.org/558163002/diff/1/Source/core/dom/DOMPointInit.idl File Source/core/dom/DOMPointInit.idl (right): https://codereview.chromium.org/558163002/diff/1/Source/core/dom/DOMPointInit.idl#newcode4 Source/core/dom/DOMPointInit.idl:4: On 2014/09/10 15:37:40, haraken wrote: ...
6 years, 3 months ago (2014-09-12 04:16:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558163002/20001
6 years, 3 months ago (2014-09-12 04:38:32 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 05:18:11 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 181877

Powered by Google App Engine
This is Rietveld 408576698