Convert animation and renderer code to know about BorderImageLength

Source/platform/BorderImageLengthBox.h

 /*
  * Copyright (c) 2013, Opera Software ASA. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 14 matching lines @@
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
 #ifndef BorderImageLengthBox_h
 #define BorderImageLengthBox_h
 
 #include "platform/BorderImageLength.h"
-#include "platform/LengthBox.h"
 
 namespace WebCore {
 
 class PLATFORM_EXPORT BorderImageLengthBox {
 public:
     BorderImageLengthBox()
     {
     }
 
     BorderImageLengthBox(Length t, Length r, Length b, Length l)

[Julien - ping for review, 2013/11/04 18:15:54]

Do we still want to keep this constructor?

         : m_left(l)
         , m_right(r)
         , m_top(t)
         , m_bottom(b)
     {
     }
 
     BorderImageLengthBox(double t, double r, double b, double l)
         : m_left(l)
         , m_right(r)
         , m_top(t)
         , m_bottom(b)
     {
     }
 
-    // FIXME: Remove when the conversion to BorderImageLengthBox is complete
-    explicit BorderImageLengthBox(LengthBox lengthBox)
-        : m_left(lengthBox.m_left)
-        , m_right(lengthBox.m_right)
-        , m_top(lengthBox.m_top)
-        , m_bottom(lengthBox.m_bottom)
+    BorderImageLengthBox(const BorderImageLength& t, const BorderImageLength& r, const BorderImageLength& b, const BorderImageLength& l)

[Julien - ping for review, 2013/11/04 18:15:54]

Remember my stick about |o|, well it applies also to |t|, |r|, |b| and |l| (and
most one letter variable names)

[davve, 2013/11/07 13:18:45]

OK.

+        : m_left(l)
+        , m_right(r)
+        , m_top(t)
+        , m_bottom(b)
     {
     }
 
     const BorderImageLength& left() const { return m_left; }
     const BorderImageLength& right() const { return m_right; }
     const BorderImageLength& top() const { return m_top; }
     const BorderImageLength& bottom() const { return m_bottom; }
 
     void setLeft(const BorderImageLength& left) { m_left = left; }
     void setRight(const BorderImageLength& right) { m_right = right; }
     void setTop(const BorderImageLength& top) { m_top = top; }
     void setBottom(const BorderImageLength& bottom) { m_bottom = bottom; }
 
     bool operator==(const BorderImageLengthBox& other) const
     {
         return m_left == other.m_left && m_right == other.m_right
             && m_top == other.m_top && m_bottom == other.m_bottom;
     }
 
     bool operator!=(const BorderImageLengthBox& other) const
     {
         return !(*this == other);
     }
 
     bool nonZero() const
     {
         return !(m_left.isZero() && m_right.isZero() && m_top.isZero() && m_bottom.isZero());
     }
 
-    // FIXME: Remove when the conversion to BorderImageLengthBox is complete
-    LengthBox deprecatedLengthBox() const
-    {
-        return LengthBox(m_top.deprecatedUnifiedLength(), m_right.deprecatedUnifiedLength(),
-            m_bottom.deprecatedUnifiedLength(), m_left.deprecatedUnifiedLength());
-    }
-
 private:
     BorderImageLength m_left;
     BorderImageLength m_right;
     BorderImageLength m_top;
     BorderImageLength m_bottom;
 };
 
 } // namespace WebCore
 
 #endif // BorderImageLengthBox_h