Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 558103003: [SCM tests] Don't forget to change back to original cwd. (Closed)

Created:
6 years, 3 months ago by elecro
Modified:
6 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[SCM tests] Don't forget to change back to original cwd. After removing the temporary SCM directory change back to the original cwd. This will avoid errors on future os.cwd() calls. BUG=412774 TEST=test-webkitpy --all Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M Tools/Scripts/webkitpy/common/checkout/scm/scm_unittest.py View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
elecro
6 years, 3 months ago (2014-09-10 14:43:25 UTC) #2
Dirk Pranke
This change seems safe, but unnecessary. I think most if not all of the subsequent ...
6 years, 3 months ago (2014-09-10 20:09:01 UTC) #3
elecro
On 2014/09/10 20:09:01, Dirk Pranke wrote: > This change seems safe, but unnecessary. I think ...
6 years, 3 months ago (2014-09-11 08:23:54 UTC) #4
Dirk Pranke
On 2014/09/11 08:23:54, elecro wrote: > On 2014/09/10 20:09:01, Dirk Pranke wrote: > > This ...
6 years, 3 months ago (2014-09-12 01:56:07 UTC) #5
elecro
On 2014/09/12 01:56:07, Dirk Pranke wrote: [snip] > I wonder if you have a different ...
6 years, 3 months ago (2014-09-12 09:32:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558103003/1
6 years, 3 months ago (2014-09-12 11:05:33 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 12:07:42 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181894

Powered by Google App Engine
This is Rietveld 408576698