[cc] Add nearest neighbor filtering for TextureLayer.

cc/blink/web_external_texture_layer_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_BLINK_WEB_EXTERNAL_TEXTURE_LAYER_IMPL_H_
 #define CC_BLINK_WEB_EXTERNAL_TEXTURE_LAYER_IMPL_H_
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/scoped_vector.h"
 #include "cc/blink/cc_blink_export.h"
 #include "cc/layers/texture_layer_client.h"
 #include "third_party/WebKit/public/platform/WebExternalTextureLayer.h"
+#include "third_party/skia/include/core/SkPaint.h"
 
 namespace blink {
 struct WebFloatRect;
 struct WebExternalTextureMailbox;
 }
 
 namespace cc {
 class SingleReleaseCallback;
 class TextureMailbox;
 }
@@ skipping 12 matching lines @@
       blink::WebExternalTextureLayerClient*);
   virtual ~WebExternalTextureLayerImpl();
 
   // blink::WebExternalTextureLayer implementation.
   virtual blink::WebLayer* layer();
   virtual void clearTexture();
   virtual void setOpaque(bool opaque);
   virtual void setPremultipliedAlpha(bool premultiplied);
   virtual void setBlendBackgroundColor(bool blend);
   virtual void setRateLimitContext(bool rate_limit);
+  virtual void setFilterLevel(SkPaint::FilterLevel filter_level);

[danakj, 2014/11/04 16:02:42]

since this function only handles none vs not-none, i think a setNearestNeighbour
would be more appropriate, but, see comment in the .cc.

[jackhou1, 2014/11/12 03:35:17]

I was recommended to use an enum on the other CL (crrev.com/562583002), but we
can discuss with junov/senorblanco if you feel strongly about it.

[danakj, 2014/11/12 18:10:14]

I guess different owners with different tastes. I'd prefer to optimize for the
simplest possible API now, rather than potential future changes that are
uncertain.

If they want an enum you can turn that into a bool at some level before the call
to this method?

 
   // TextureLayerClient implementation.
   bool PrepareTextureMailbox(
       cc::TextureMailbox* mailbox,
       scoped_ptr<cc::SingleReleaseCallback>* release_callback,
       bool use_shared_memory) override;
 
  private:
   static void DidReleaseMailbox(
       base::WeakPtr<WebExternalTextureLayerImpl> layer,
       const blink::WebExternalTextureMailbox& mailbox,
       WebExternalBitmapImpl* bitmap,
       unsigned sync_point,
       bool lost_resource);
 
   WebExternalBitmapImpl* AllocateBitmap();
 
   blink::WebExternalTextureLayerClient* client_;
   scoped_ptr<WebLayerImpl> layer_;
   ScopedVector<WebExternalBitmapImpl> free_bitmaps_;
 
+  bool nearest_neighbor_;

[danakj, 2014/11/04 16:02:42]

unused?

[jackhou1, 2014/11/12 03:35:17]

Removed.

+
   DISALLOW_COPY_AND_ASSIGN(WebExternalTextureLayerImpl);
 };
 
 }  // namespace cc_blink
 
 #endif  // CC_BLINK_WEB_EXTERNAL_TEXTURE_LAYER_IMPL_H_