Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart

Issue 558063002: Modify JS annotations in runtime typedef handling to not drag in native types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
diff --git a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
index 5d3d8d069c0267074cd782751f8b3965b6b25e31..3ff978985ee12103d4ce7d14321962885c4c89b2 100644
--- a/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
+++ b/sdk/lib/_internal/compiler/js_lib/js_mirrors.dart
@@ -2765,10 +2765,10 @@ TypeMirror typeMirrorFromRuntimeTypeRepresentation(
return reflectClassByMangledName(
getMangledTypeName(createRuntimeType(representation)));
}
- if (type != null && JS('Object|Null', '#.typedef', type) != null) {
+ if (type != null && JS('', '#.typedef', type) != null) {
return typeMirrorFromRuntimeTypeRepresentation(
- owner, JS('Object', '#.typedef', type));
- } else if (type != null && JS('Object|Null', '#.func', type) != null) {
+ owner, JS('', '#.typedef', type));
+ } else if (type != null && JS('', '#.func', type) != null) {
return new JsFunctionTypeMirror(type, owner);
}
return reflectClass(Function);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698