src/IceInst.cpp - Issue 557953007: Subzero: Fix incorrect address mode inference involving Phi temporaries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInst.cpp

Issue 557953007: Subzero: Fix incorrect address mode inference involving Phi temporaries. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Add check against Var2->getIsMultidef() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInst.cpp

diff --git a/src/IceInst.cpp b/src/IceInst.cpp

index 43291ced46fb749a926943f93ddbe1c43d1fcb87..b84266aa1a0ca80aa2fc8e0aa27a4cd85d49f35a 100644

--- a/src/IceInst.cpp

+++ b/src/IceInst.cpp

@@ -359,6 +359,7 @@ Inst *InstPhi::lower(Cfg *Func, CfgNode *Node) {

assert(Dest);

IceString PhiName = Dest->getName() + "_phi";

Variable *NewSrc = Func->makeVariable(Dest->getType(), Node, PhiName);

+ NewSrc->setIsMultidef();

this->Dest = NewSrc;

InstAssign *NewInst = InstAssign::create(Func, Dest, NewSrc);

// Set Dest and NewSrc to have affinity with each other, as a hint

« no previous file with comments | « no previous file | src/IceOperand.h » ('j') | no next file with comments »