components/startup_metric_utils/startup_metric_utils.cc - Issue 557953006: Avoid using ToInternalValue in computing timings, so that the timings are consistent accross platfo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/startup_metric_utils/startup_metric_utils.cc

Issue 557953006: Avoid using ToInternalValue in computing timings, so that the timings are consistent accross platfo… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/startup_metric_utils/startup_metric_utils.cc

diff --git a/components/startup_metric_utils/startup_metric_utils.cc b/components/startup_metric_utils/startup_metric_utils.cc

index 255cc177fe0f744360b06cbfb04821d1fc418753..642a0c488823b675c2468a2098e0277227823212 100644

--- a/components/startup_metric_utils/startup_metric_utils.cc

+++ b/components/startup_metric_utils/startup_metric_utils.cc

@@ -47,8 +47,7 @@ void RecordMainEntryTimeHistogram() {

const int kLowWordMask = 0xFFFFFFFF;

const int kLower31BitsMask = 0x7FFFFFFF;

base::TimeDelta browser_main_entry_time_absolute =

- base::TimeDelta::FromMilliseconds(

- MainEntryPointTimeInternal()->ToInternalValue() / 1000.0);

+ *MainEntryPointTimeInternal() - base::Time::UnixEpoch();

uint64 browser_main_entry_time_raw_ms =

browser_main_entry_time_absolute.InMilliseconds();

« no previous file with comments | « no previous file | content/renderer/stats_collection_controller.cc » ('j') | content/renderer/stats_collection_controller.cc » ('J')