Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2396)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 557953005: Allow the user to "repair" a corrupted extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 12a0d4b73339a6f57a5b44e83d1e45f5b2f00026..6e8db4a87dd44439e43a4619cc42d4f887acb08a 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -31,6 +31,7 @@
* installWarnings: (Array|undefined),
* is_hosted_app: boolean,
* is_platform_app: boolean,
+ * isFromStore: boolean,
* isUnpacked: boolean,
* kioskEnabled: boolean,
* kioskOnly: boolean,
@@ -319,7 +320,19 @@ cr.define('options', function() {
}
}
- if (!extension.terminated) {
+ if (extension.terminated) {
+ var terminatedReload = node.querySelector('.terminated-reload-link');
+ terminatedReload.hidden = false;
+ terminatedReload.addEventListener('click', function(e) {
Dan Beam 2014/09/18 21:36:49 could this add event listeners more than once (mea
Devlin 2014/09/19 21:30:08 I'm pretty sure it's not a risk - this is all in c
+ chrome.send('extensionSettingsReload', [extension.id]);
+ });
+ } else if (extension.corruptInstall && extension.isFromStore) {
+ var repair = node.querySelector('.corrupted-repair-button');
+ repair.hidden = false;
+ repair.addEventListener('click', function(e) {
Dan Beam 2014/09/18 21:36:49 same
Devlin 2014/09/19 21:30:08 Done.
+ chrome.send('extensionSettingsRepair', [extension.id]);
+ });
+ } else {
// The 'Enabled' checkbox.
var enable = node.querySelector('.enable-checkbox');
enable.hidden = false;
@@ -350,12 +363,6 @@ cr.define('options', function() {
}
enable.querySelector('input').checked = extension.enabled;
- } else {
- var terminatedReload = node.querySelector('.terminated-reload-link');
- terminatedReload.hidden = false;
- terminatedReload.addEventListener('click', function(e) {
- chrome.send('extensionSettingsReload', [extension.id]);
- });
}
// 'Remove' button.

Powered by Google App Engine
This is Rietveld 408576698