Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Issue 557953004: Makes GetClipBounds() return the enclosing rect (Closed)

Created:
6 years, 3 months ago by sky
Modified:
6 years, 3 months ago
Reviewers:
danakj
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Makes GetClipBounds() return the enclosing rect The current code floors, which means we may not paint enough, an in fact you can see this in views at certain scales. BUG=none TEST=none R=danakj@chromium.org Committed: https://crrev.com/e7da6040401dbb0572c3eddb2c31ae58a36a9d76 Cr-Commit-Position: refs/heads/master@{#294244}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M ui/gfx/canvas.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M ui/gfx/canvas_unittest.cc View 2 chunks +14 lines, -0 lines 3 comments Download

Messages

Total messages: 12 (3 generated)
sky
6 years, 3 months ago (2014-09-10 17:33:49 UTC) #1
danakj
LGTM https://codereview.chromium.org/557953004/diff/1/ui/gfx/canvas_unittest.cc File ui/gfx/canvas_unittest.cc (right): https://codereview.chromium.org/557953004/diff/1/ui/gfx/canvas_unittest.cc#newcode55 ui/gfx/canvas_unittest.cc:55: canvas.sk_canvas()->clipRect(RectFToSkRect(gfx::RectF(100, 0, 20, 1.7f))); nit: 1.2 to show ...
6 years, 3 months ago (2014-09-10 18:27:16 UTC) #2
sky
https://codereview.chromium.org/557953004/diff/1/ui/gfx/canvas_unittest.cc File ui/gfx/canvas_unittest.cc (right): https://codereview.chromium.org/557953004/diff/1/ui/gfx/canvas_unittest.cc#newcode55 ui/gfx/canvas_unittest.cc:55: canvas.sk_canvas()->clipRect(RectFToSkRect(gfx::RectF(100, 0, 20, 1.7f))); On 2014/09/10 18:27:16, danakj wrote: ...
6 years, 3 months ago (2014-09-10 18:29:51 UTC) #3
danakj
https://codereview.chromium.org/557953004/diff/1/ui/gfx/canvas_unittest.cc File ui/gfx/canvas_unittest.cc (right): https://codereview.chromium.org/557953004/diff/1/ui/gfx/canvas_unittest.cc#newcode55 ui/gfx/canvas_unittest.cc:55: canvas.sk_canvas()->clipRect(RectFToSkRect(gfx::RectF(100, 0, 20, 1.7f))); On 2014/09/10 18:29:51, sky wrote: ...
6 years, 3 months ago (2014-09-10 18:32:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/557953004/1
6 years, 3 months ago (2014-09-10 18:38:26 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-10 21:05:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/557953004/1
6 years, 3 months ago (2014-09-10 21:21:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as b02ef65069406732afaf800d76890fae5f7c9875
6 years, 3 months ago (2014-09-10 22:20:37 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 22:26:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e7da6040401dbb0572c3eddb2c31ae58a36a9d76
Cr-Commit-Position: refs/heads/master@{#294244}

Powered by Google App Engine
This is Rietveld 408576698