Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 557883002: Prefixing 'aria-' in names of .html files related to aria role. (Closed)

Created:
6 years, 3 months ago by shreeramk
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Prefixing 'aria-' in names of .html files related to aria role. For aria role like spinbutton, button, toolbar, the corresponding .html files are without 'aria-' prefix which might cause confusion. So, prefixing 'aria-' with those missed .html files. Committed: https://crrev.com/f1c965cb43484fec03a3b0cd302a32583778e2aa Cr-Commit-Position: refs/heads/master@{#294137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -55 lines) Patch
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 5 chunks +16 lines, -15 lines 0 comments Download
A + content/test/data/accessibility/aria-spinbutton.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-spinbutton-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-spinbutton-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-spinbutton-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-togglebutton.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-togglebutton-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-togglebutton-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-togglebutton-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-toolbar.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-toolbar-expected-android.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-toolbar-expected-mac.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/test/data/accessibility/aria-toolbar-expected-win.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
D content/test/data/accessibility/spinbutton.html View 1 chunk +0 lines, -8 lines 0 comments Download
D content/test/data/accessibility/spinbutton-expected-android.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/data/accessibility/spinbutton-expected-mac.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/data/accessibility/spinbutton-expected-win.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/data/accessibility/togglebutton.html View 1 chunk +0 lines, -11 lines 0 comments Download
D content/test/data/accessibility/togglebutton-expected-android.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/togglebutton-expected-mac.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D content/test/data/accessibility/togglebutton-expected-win.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/toolbar.html View 1 chunk +0 lines, -9 lines 0 comments Download
D content/test/data/accessibility/toolbar-expected-android.txt View 1 chunk +0 lines, -2 lines 0 comments Download
D content/test/data/accessibility/toolbar-expected-mac.txt View 1 chunk +0 lines, -3 lines 0 comments Download
D content/test/data/accessibility/toolbar-expected-win.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review. Thanks!
6 years, 3 months ago (2014-09-10 02:57:16 UTC) #2
dmazzoni
lgtm Thanks, good cleanup.
6 years, 3 months ago (2014-09-10 05:42:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shreeram.k@samsung.com/557883002/1
6 years, 3 months ago (2014-09-10 05:53:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 847f7e934deefd228a45e2ccfa4497743f940ef5
6 years, 3 months ago (2014-09-10 07:58:02 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 08:00:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1c965cb43484fec03a3b0cd302a32583778e2aa
Cr-Commit-Position: refs/heads/master@{#294137}

Powered by Google App Engine
This is Rietveld 408576698