Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 557833007: Remove Increment/DecrementKeepAliveCount from AppsClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | extensions/browser/app_window/app_window_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/app_window/app_window.cc
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
index 475ac628bf662866add4e7985b0849474d601e4e..2b01864f79e7af75b408d8eb11099207a5f26671 100644
--- a/extensions/browser/app_window/app_window.cc
+++ b/extensions/browser/app_window/app_window.cc
@@ -285,8 +285,6 @@ void AppWindow::Init(const GURL& url,
new web_modal::PopupManager(GetWebContentsModalDialogHost()));
popup_manager_->RegisterWith(web_contents);
- // Prevent the browser process from shutting down while this window exists.
- app_window_client->IncrementKeepAliveCount();
UpdateExtensionAppIcon();
AppWindowRegistry::Get(browser_context_)->AddAppWindow(this);
@@ -331,13 +329,7 @@ void AppWindow::Init(const GURL& url,
}
AppWindow::~AppWindow() {
- // Unregister now to prevent getting notified if we're the last window open.
- app_delegate_->SetTerminatingCallback(base::Closure());
-
ExtensionRegistry::Get(browser_context_)->RemoveObserver(this);
-
- // Remove shutdown prevention.
- AppWindowClient::Get()->DecrementKeepAliveCount();
}
void AppWindow::RequestMediaAccessPermission(
« no previous file with comments | « chrome/chrome_browser_ui.gypi ('k') | extensions/browser/app_window/app_window_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698