extensions/browser/app_window/app_window.cc - Issue 557833007: Remove Increment/DecrementKeepAliveCount from AppsClient

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 557833007: Remove Increment/DecrementKeepAliveCount from AppsClient (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Pass ScopedKeepAlive Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc ('K') | « chrome/chrome_browser_ui.gypi ('k') | extensions/browser/app_window/app_window_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/app_window/app_window.cc

diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc

index 475ac628bf662866add4e7985b0849474d601e4e..2b01864f79e7af75b408d8eb11099207a5f26671 100644

--- a/extensions/browser/app_window/app_window.cc

+++ b/extensions/browser/app_window/app_window.cc

@@ -285,8 +285,6 @@ void AppWindow::Init(const GURL& url,

new web_modal::PopupManager(GetWebContentsModalDialogHost()));

popup_manager_->RegisterWith(web_contents);

- // Prevent the browser process from shutting down while this window exists.

- app_window_client->IncrementKeepAliveCount();

UpdateExtensionAppIcon();

AppWindowRegistry::Get(browser_context_)->AddAppWindow(this);

@@ -331,13 +329,7 @@ void AppWindow::Init(const GURL& url,

}

AppWindow::~AppWindow() {

- // Unregister now to prevent getting notified if we're the last window open.

- app_delegate_->SetTerminatingCallback(base::Closure());

ExtensionRegistry::Get(browser_context_)->RemoveObserver(this);

- // Remove shutdown prevention.

- AppWindowClient::Get()->DecrementKeepAliveCount();

}

void AppWindow::RequestMediaAccessPermission(