Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Side by Side Diff: chrome/service/cloud_print/printer_job_handler.h

Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the WeakPtr comments in files Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/upgrade_detector_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_ 5 #ifndef CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
6 #define CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_ 6 #define CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 // Some task in the state machine is in progress. 296 // Some task in the state machine is in progress.
297 bool task_in_progress_; 297 bool task_in_progress_;
298 scoped_refptr<PrintSystem::PrinterWatcher> printer_watcher_; 298 scoped_refptr<PrintSystem::PrinterWatcher> printer_watcher_;
299 typedef std::list< scoped_refptr<JobStatusUpdater> > JobStatusUpdaterList; 299 typedef std::list< scoped_refptr<JobStatusUpdater> > JobStatusUpdaterList;
300 JobStatusUpdaterList job_status_updater_list_; 300 JobStatusUpdaterList job_status_updater_list_;
301 301
302 // Manages parsing the job queue 302 // Manages parsing the job queue
303 PrinterJobQueueHandler job_queue_handler_; 303 PrinterJobQueueHandler job_queue_handler_;
304 304
305 base::TimeTicks last_job_fetch_time_; 305 base::TimeTicks last_job_fetch_time_;
306 base::WeakPtrFactory<PrinterJobHandler> weak_ptr_factory_;
307 306
308 base::Time job_start_time_; 307 base::Time job_start_time_;
309 base::Time spooling_start_time_; 308 base::Time spooling_start_time_;
310 base::Time last_caps_update_time_; 309 base::Time last_caps_update_time_;
311 310
311 base::WeakPtrFactory<PrinterJobHandler> weak_ptr_factory_;
312
312 DISALLOW_COPY_AND_ASSIGN(PrinterJobHandler); 313 DISALLOW_COPY_AND_ASSIGN(PrinterJobHandler);
313 }; 314 };
314 315
315 // This typedef is to workaround the issue with certain versions of 316 // This typedef is to workaround the issue with certain versions of
316 // Visual Studio where it gets confused between multiple Delegate 317 // Visual Studio where it gets confused between multiple Delegate
317 // classes and gives a C2500 error. (I saw this error on the try bots - 318 // classes and gives a C2500 error. (I saw this error on the try bots -
318 // the workaround was not needed for my machine). 319 // the workaround was not needed for my machine).
319 typedef PrinterJobHandler::Delegate PrinterJobHandlerDelegate; 320 typedef PrinterJobHandler::Delegate PrinterJobHandlerDelegate;
320 321
321 } // namespace cloud_print 322 } // namespace cloud_print
322 323
323 #endif // CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_ 324 #endif // CHROME_SERVICE_CLOUD_PRINT_PRINTER_JOB_HANDLER_H_
OLDNEW
« no previous file with comments | « chrome/browser/upgrade_detector_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698