chrome/browser/sync/sessions/notification_service_sessions_router.h - Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/sync/sessions/notification_service_sessions_router.h

Issue 557833006: Fix WeakPtrFactory member ordering in chrome/browser and chrome/service (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed the WeakPtr comments in files Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/sessions/base_session_service.cc ('k') | chrome/browser/upgrade_detector_impl.h » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_SYNC_SESSIONS_NOTIFICATION_SERVICE_SESSIONS_ROUTER_H_	5 #ifndef CHROME_BROWSER_SYNC_SESSIONS_NOTIFICATION_SERVICE_SESSIONS_ROUTER_H_

6 #define CHROME_BROWSER_SYNC_SESSIONS_NOTIFICATION_SERVICE_SESSIONS_ROUTER_H_	6 #define CHROME_BROWSER_SYNC_SESSIONS_NOTIFICATION_SERVICE_SESSIONS_ROUTER_H_

7	7

8 #include <set>	8 #include <set>

9	9

10 #include "base/callback_list.h"	10 #include "base/callback_list.h"

(...skipping 41 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
52 // from WebContents.	52 // from WebContents.

53 void OnNavigationBlocked(content::WebContents* web_contents);	53 void OnNavigationBlocked(content::WebContents* web_contents);

54	54

55 // Called when the urls of favicon changed.	55 // Called when the urls of favicon changed.

56 void OnFaviconChanged(const std::set<GURL>& changed_favicons);	56 void OnFaviconChanged(const std::set<GURL>& changed_favicons);

57	57

58 LocalSessionEventHandler* handler_;	58 LocalSessionEventHandler* handler_;

59 content::NotificationRegistrar registrar_;	59 content::NotificationRegistrar registrar_;

60 Profile* const profile_;	60 Profile* const profile_;

61 syncer::SyncableService::StartSyncFlare flare_;	61 syncer::SyncableService::StartSyncFlare flare_;

62 base::WeakPtrFactory<NotificationServiceSessionsRouter> weak_ptr_factory_;

63	62

64 scoped_ptr<base::CallbackList<void(const std::set<GURL>&)>::Subscription>	63 scoped_ptr<base::CallbackList<void(const std::set<GURL>&)>::Subscription>

65 favicon_changed_subscription_;	64 favicon_changed_subscription_;

66	65

	66 base::WeakPtrFactory<NotificationServiceSessionsRouter> weak_ptr_factory_;

	67

67 DISALLOW_COPY_AND_ASSIGN(NotificationServiceSessionsRouter);	68 DISALLOW_COPY_AND_ASSIGN(NotificationServiceSessionsRouter);

68 };	69 };

69	70

70 } // namespace browser_sync	71 } // namespace browser_sync

71	72

72 #endif // CHROME_BROWSER_SYNC_SESSIONS_NOTIFICATION_SERVICE_SESSIONS_ROUTER_H_	73 #endif // CHROME_BROWSER_SYNC_SESSIONS_NOTIFICATION_SERVICE_SESSIONS_ROUTER_H_

OLD	NEW