Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl

Issue 55783002: Introduce BorderImageLength and BorderImageLengthBox (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
diff --git a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
index b0317752f88ab0b94ddf6a48674e891540b3a39f..6dc8fb0d848e91a2ed1467375faf1dd0a3a99c5a 100644
--- a/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
+++ b/Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl
@@ -179,7 +179,7 @@ namespace WebCore {
{
NinePieceImage image(state.style()->{{getter}}());
{%- if modifier_type == "Outset" %}
- image.setOutset(LengthBox(0));
+ image.setOutset(LengthOrNumberBox({{ (["Length(0, Fixed)"]*4) | join(", ") }}));
Julien - ping for review 2013/11/01 18:27:11 We modify this call to setOutset() but leave the o
davve 2013/11/04 12:42:54 I don't follow. Could you give an example?
Julien - ping for review 2013/11/04 16:31:40 Mhh, it looks like I was the one confused and thou
{%- elif modifier_type == "Repeat" %}
image.setHorizontalRule(StretchImageRule);
image.setVerticalRule(StretchImageRule);
@@ -189,7 +189,7 @@ namespace WebCore {
image.setFill(false);
{%- elif modifier_type == "Width" %}
// Masks have a different initial value for widths. Preserve the value of 0 for backwards compatibility.
- image.setBorderSlices(LengthBox({{ (["Length(1, Relative)"]*4) | join(", ") if not is_mask_box }}));
+ image.setBorderSlices(LengthOrNumberBox({{ (["1.0"]*4) | join(", ") if not is_mask_box }}));
{%- endif %}
state.style()->{{setter}}(image);
}
« no previous file with comments | « no previous file | Source/core/css/CSSComputedStyleDeclaration.cpp » ('j') | Source/core/css/CSSComputedStyleDeclaration.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698