Introduce BorderImageLength and BorderImageLengthBox

Source/platform/LengthOrNumber.h

 /*
-    Copyright (C) 1999 Lars Knoll (knoll@kde.org)
-    Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
+    Copyright (c) 2013, Opera Software ASA. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
     version 2 of the License, or (at your option) any later version.
 
     This library is distributed in the hope that it will be useful,
     but WITHOUT ANY WARRANTY; without even the implied warranty of
     MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
     Library General Public License for more details.
 
     You should have received a copy of the GNU Library General Public License
     along with this library; see the file COPYING.LIB.  If not, write to
     the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
     Boston, MA 02110-1301, USA.
 */

[Julien - ping for review, 2013/11/01 18:27:11]

AFAICT Blink prefers a BSD license for new files unless you explicitly copied
from an existing one (http://www.chromium.org/blink/coding-style#TOC-License)

Also git seems to think this is a copy of LengthSize. You may want to use git cl
upload --no-find-copies to remove this smart copy detection.

[davve, 2013/11/04 12:42:54]

OK.

 
-#ifndef LengthSize_h
-#define LengthSize_h
+#ifndef LengthOrNumber_h
+#define LengthOrNumber_h
 
 #include "platform/Length.h"
 
 namespace WebCore {
 
-struct LengthSize {
+class PLATFORM_EXPORT LengthOrNumber {
 public:
-    LengthSize()
+    LengthOrNumber()
     {
     }
 
-    LengthSize(Length width, Length height)
-        : m_width(width)
-        , m_height(height)
+    LengthOrNumber(double number)
+        : m_length(number, Relative)
     {
     }
 
-    bool operator==(const LengthSize& o) const
+    explicit LengthOrNumber(const Length& length)
+        : m_length(length)
     {
-        return m_width == o.m_width && m_height == o.m_height;
     }
 
-    void setWidth(Length width) { m_width = width; }
-    Length width() const { return m_width; }
+    bool isNumber() const { return m_length.isRelative(); }
+    bool isLength() const { return !isNumber(); }
 
-    void setHeight(Length height) { m_height = height; }
-    Length height() const { return m_height; }
+    const Length& length() const { ASSERT(isLength()); return m_length; }
+    Length& length() { ASSERT(isLength()); return m_length; }
+
+    double number() const { ASSERT(isNumber()); return m_length.value(); }
+
+    Length unifiedLength() const { return m_length; }

[Julien - ping for review, 2013/11/01 18:27:11]

Ideally this shouldn't exist but we have to integrate with the current code. I
would name it deprecatedUnifiedLength() to show that people should _not_ use
this function.

[davve, 2013/11/04 12:42:54]

Good idea. Renamed to deprecatedUnifiedLength().

+
+    bool operator==(const LengthOrNumber& o) const
+    {
+        return m_length == o.m_length;
+    }
+
+    bool isZero() const
+    {
+        return m_length.isZero();
+    }
 
 private:
-    Length m_width;
-    Length m_height;
+    Length m_length;
 };
 
 } // namespace WebCore
 
-#endif // LengthSize_h
+#endif // LengthOrNumber_h