Issue 557823003: Revert "Merge FontPlatformDataHarfBuzz into FontPlatformData"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 557823003: Revert "Merge FontPlatformDataHarfBuzz into FontPlatformData" (Closed)

Created:
6 years, 3 months ago by loislo

Modified:
6 years, 3 months ago

Reviewers:
Dominik Röttsches, jianli

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Revert "Merge FontPlatformDataHarfBuzz into FontPlatformData" This reverts commit 44cef15dcdbf3b78339c3678fe533f3a97e59870. The patch were reverted due to problem with uninitialized memory. BUG=413229 TBR= jianli@chromium.org, dominik.rottsches@intel.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181824

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+312 lines, -222 lines)			Patch
M	Source/platform/BUILD.gn	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/platform/blink_platform.gyp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/platform/blink_platform.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/platform/fonts/FontPlatformData.h	View	4 chunks	+5 lines, -4 lines	0 comments	Download
M	Source/platform/fonts/FontPlatformData.cpp	View	4 chunks	+16 lines, -212 lines	0 comments	Download
M	Source/platform/fonts/cocoa/FontPlatformDataCocoa.mm	View	8 chunks	+55 lines, -6 lines	0 comments	Download
A	Source/platform/fonts/harfbuzz/FontPlatformDataHarfBuzz.cpp	View	1 chunk	+227 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/557823003/1

6 years, 3 months ago (2014-09-11 15:11:03 UTC) #3

loislo

6 years, 3 months ago (2014-09-11 15:45:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 181824 (presubmit successful).