Issue 557793002: Enhance the MachMessageServer test to cover large messages (MACH_RCV_LARGE)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 557793002: Enhance the MachMessageServer test to cover large messages (MACH_RCV_LARGE) (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Enhance the MachMessageServer test to cover large messages (MACH_RCV_LARGE). This also adds a COMPILE_ASSERT to check that the PersistentNonblockingFourMessages test case is not exceeding the value of MACH_PORT_QLIMIT_DEFAULT. TEST=util_test MachMessageServer.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/f1202a08142e069ade0c105e5e3c67b1b710c125

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add a COMPILE_ASSERT where MACH_PORT_QLIMIT_DEFAULT is relevant #

Patch Set 3 : Address review feedback #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+102 lines, -10 lines)			Patch
	M	util/mach/mach_message_server.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	util/mach/mach_message_server_test.cc	View	1 2	17 chunks	+100 lines, -9 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Mark Mentovai

I think this is the last of the Mach messaging tests. I’m pretty sure that ...

6 years, 3 months ago (2014-09-09 14:33:19 UTC) #2

Robert Sesek

LGTM https://codereview.chromium.org/557793002/diff/1/util/mach/mach_message_server_test.cc File util/mach/mach_message_server_test.cc (right): https://codereview.chromium.org/557793002/diff/1/util/mach/mach_message_server_test.cc#newcode412 util/mach/mach_message_server_test.cc:412: // sent will be a normal RequestMessage due ...

6 years, 3 months ago (2014-09-09 15:34:16 UTC) #3

Mark Mentovai

6 years, 3 months ago (2014-09-09 16:28:41 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as f1202a0 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages