Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: components/autofill/content/renderer/password_autofill_agent.h

Issue 557703002: Refactoring PasswordAutofillAgent::FillUserNameAndPassword function. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/password_autofill_agent.h
diff --git a/components/autofill/content/renderer/password_autofill_agent.h b/components/autofill/content/renderer/password_autofill_agent.h
index b6ab805249072b320e82ee9c9fa01dbc0b81acc1..292abab35ad687ca907e133233b615b741c68cfc 100644
--- a/components/autofill/content/renderer/password_autofill_agent.h
+++ b/components/autofill/content/renderer/password_autofill_agent.h
@@ -180,6 +180,20 @@ class PasswordAutofillAgent : public content::RenderViewObserver {
bool exact_username_match,
bool set_selection);
+ // Helper function to check additional names for a match in login collection.
+ void CheckLoginCollectionForMatch(const PasswordFormFillData& fill_data,
+ const base::string16 current_username,
+ const bool exact_username_match,
+ base::string16& username,
+ base::string16& password);
+
+ // Helper function to check names for a match in usernames collection.
+ void CheckUsernamesCollectionForMatch(const PasswordFormFillData& fill_data,
+ const base::string16 current_username,
+ const bool exact_username_match,
+ base::string16& username,
+ base::string16& password);
+
// Fills |login_input| and |password| with the most relevant suggestion from
// |fill_data| and shows a popup with other suggestions.
void PerformInlineAutocomplete(

Powered by Google App Engine
This is Rietveld 408576698