Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2131)

Unified Diff: ash/wm/workspace/workspace_window_resizer_unittest.cc

Issue 557693002: [Ash] Only snap windows that can maximize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update tests. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ash/wm/window_state_unittest.cc ('K') | « ash/wm/window_state_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/workspace/workspace_window_resizer_unittest.cc
diff --git a/ash/wm/workspace/workspace_window_resizer_unittest.cc b/ash/wm/workspace/workspace_window_resizer_unittest.cc
index cd134450fe95f0a47dfc9ba9a48b668a831ef06a..bb580d2b237ef90c196ecdb6ce801e205399329c 100644
--- a/ash/wm/workspace/workspace_window_resizer_unittest.cc
+++ b/ash/wm/workspace/workspace_window_resizer_unittest.cc
@@ -556,6 +556,7 @@ TEST_F(WorkspaceWindowResizerTest, Edge) {
// http://crbug.com/292238.
// Window is wide enough not to get docked right away.
window_->SetBounds(gfx::Rect(20, 30, 400, 60));
+ window_->SetProperty(aura::client::kCanMaximizeKey, true);
oshima 2014/09/10 15:59:32 this is because this CL changed the default value.
wm::WindowState* window_state = wm::GetWindowState(window_.get());
{
@@ -1415,6 +1416,7 @@ TEST_F(WorkspaceWindowResizerTest, MagneticallyResize_LEFT) {
// Test that the user user moved window flag is getting properly set.
TEST_F(WorkspaceWindowResizerTest, CheckUserWindowManagedFlags) {
window_->SetBounds(gfx::Rect( 0, 50, 400, 200));
+ window_->SetProperty(aura::client::kCanMaximizeKey, true);
jackhou1 2014/09/10 01:48:48 This test fails at line 1444. I'm not sure exactly
std::vector<aura::Window*> no_attached_windows;
// Check that an abort doesn't change anything.
« ash/wm/window_state_unittest.cc ('K') | « ash/wm/window_state_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698