Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1795)

Unified Diff: ash/wm/window_state_unittest.cc

Issue 557693002: [Ash] Only snap windows that can maximize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change ash_test_base.cc Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/window_state_unittest.cc
diff --git a/ash/wm/window_state_unittest.cc b/ash/wm/window_state_unittest.cc
index cef8fbbe25304830a70be20b3c77c78a07f013b6..3a457286242087d398d4705ad26795ec5b6ff556 100644
--- a/ash/wm/window_state_unittest.cc
+++ b/ash/wm/window_state_unittest.cc
@@ -9,6 +9,7 @@
#include "ash/test/ash_test_base.h"
#include "ash/wm/window_state.h"
#include "ash/wm/wm_event.h"
+#include "ui/aura/client/aura_constants.h"
#include "ui/aura/test/test_window_delegate.h"
#include "ui/aura/window.h"
@@ -124,9 +125,14 @@ TEST_F(WindowStateTest, SnapWindowMinimumSize) {
kWorkAreaBounds.height());
EXPECT_EQ(expected.ToString(), window->GetBoundsInScreen().ToString());
- // It should not be possible to snap a window with a maximum size.
- delegate.set_minimum_size(gfx::Size());
- delegate.set_maximum_size(gfx::Size(kWorkAreaBounds.width() - 1, INT_MAX));
+ // It should not be possible to snap a window with a maximum size, or if it
+ // cannot be maximized.
+ delegate.set_maximum_size(gfx::Size(kWorkAreaBounds.width() - 1, 0));
+ EXPECT_FALSE(window_state->CanSnap());
+ delegate.set_maximum_size(gfx::Size(0, kWorkAreaBounds.height() - 1));
+ EXPECT_FALSE(window_state->CanSnap());
+ delegate.set_maximum_size(gfx::Size());
+ window->SetProperty(aura::client::kCanMaximizeKey, false);
EXPECT_FALSE(window_state->CanSnap());
}

Powered by Google App Engine
This is Rietveld 408576698