[Ash] Only snap windows that can maximize.

ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc

Index: ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
index 986d041da11a1a2e511c4cb534db032f87da0be1..3cd7e6c10b4b165890972078190abeb9c910d57e 100644
--- a/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
+++ b/ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc
@@ -119,12 +119,9 @@ class MaximizeModeWindowManagerTest : public test::AshTestBase {
                                                bool can_maximize,
                                                bool can_resize) {
     aura::test::TestWindowDelegate* delegate = NULL;
-    if (!can_maximize) {
-      delegate = aura::test::TestWindowDelegate::CreateSelfDestroyingDelegate();

[oshima, 2014/09/11 17:25:49]

I wonder why this is done only when the window can't be maximzied. stefan?

[Mr4D (OOO till 08-26), 2014/09/11 20:24:17]

There are two reasons for this delegate:
1. Allow to specify a maximum size for a window which is smaller then the screen
and / or something which prevents the window from maximizing.
2. There is a drag test which makes sure that the non maximizable window in the
"maximize mode state" cannot be dragged. Thus it'll return HTCAPTION as hit test
since that would allow to do so.

Each of these attributes could be a problem for other tests and as such this is
an optional delegate. However - it appears that none of the unit tests fails
(yet) by always doing it, so it might be (for now) okay to do so, but somehow I
like it cleaner and only do this when needed. So I would keep it as is - unless
there is a particular reason for removing?

[jackhou1, 2014/09/18 02:54:59]

Done.

-      delegate->set_window_component(HTCAPTION);
-      if (!max_size.IsEmpty())
-        delegate->set_maximum_size(max_size);
-    }
+    delegate = aura::test::TestWindowDelegate::CreateSelfDestroyingDelegate();
+    delegate->set_window_component(HTCAPTION);
+    delegate->set_maximum_size(max_size);
     aura::Window* window = aura::test::CreateTestWindowWithDelegateAndType(
         delegate, type, 0, bounds, NULL);
     window->SetProperty(aura::client::kCanMaximizeKey, can_maximize);