Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Unified Diff: ui/app_list/views/apps_grid_view_unittest.cc

Issue 557673002: Split app list drop target into reorder and folder drop targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fasdaj
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/app_list/views/apps_grid_view.cc ('K') | « ui/app_list/views/apps_grid_view.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/app_list/views/apps_grid_view_unittest.cc
diff --git a/ui/app_list/views/apps_grid_view_unittest.cc b/ui/app_list/views/apps_grid_view_unittest.cc
index adee4cbe98a386824d5b73ac8f12a90269e87812..c6fd60b50d2e303a10d854db12167a69d69d1738 100644
--- a/ui/app_list/views/apps_grid_view_unittest.cc
+++ b/ui/app_list/views/apps_grid_view_unittest.cc
@@ -408,13 +408,10 @@ TEST_F(AppsGridViewTest, MouseDragMaxItemsInFolder) {
test_api_->LayoutToIdealBounds();
// Dragging the last item over the folder, the folder won't accept the new
- // item, instead, it will re-order the items.
+ // item.
Matt Giuca 2014/09/11 03:35:40 Sorry, too hard to read... can you explain what th
calamity 2014/09/11 07:05:17 Amended CL description as discussed.
SimulateDrag(AppsGridView::MOUSE, from, to);
apps_grid_view_->EndDrag(false);
EXPECT_EQ(2u, model_->top_level_item_list()->item_count());
- EXPECT_EQ(model_->GetItemName(kMaxFolderItems),
- model_->top_level_item_list()->item_at(0)->id());
- EXPECT_EQ(folder_item->id(), model_->top_level_item_list()->item_at(1)->id());
EXPECT_EQ(kMaxFolderItems, folder_item->ChildItemCount());
test_api_->LayoutToIdealBounds();
}
« ui/app_list/views/apps_grid_view.cc ('K') | « ui/app_list/views/apps_grid_view.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698