Split app list drop target into reorder and folder drop targets.

ui/app_list/views/apps_grid_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_APP_LIST_VIEWS_APPS_GRID_VIEW_H_
 #define UI_APP_LIST_VIEWS_APPS_GRID_VIEW_H_
 
 #include <set>
 #include <string>
 
@@ skipping 372 matching lines @@
   // If |hide| is set the view will get hidden, otherwise it gets shown.
   void SetViewHidden(views::View* view, bool hide, bool immediate);
 
   // Whether the folder drag-and-drop UI should be enabled.
   bool EnableFolderDragDropUI();
 
   // Whether target specified by |drap_target| can accept more items to be
   // dropped into it.
   bool CanDropIntoTarget(const Index& drop_target);
 
-  // Returns the visual index of the nearest tile in which |drag_view_| enters
-  // either its re-ordering or folder dropping circle.
-  Index GetNearestTileForDragView();
+  // Calculates the visual index of the nearest tile for which |drag_view_|
+  // enters either its re-ordering or folder dropping circle.
+  void CalculateNearestTileForDragView();
 
   // Calculates |nearest_tile| in which |vertex| of the |drag_view| is
   // enclosed.
   // *|nearest_tile| and *|d_min| will be updated based on the calculation.
   // *|d_min| is the distance between |nearest_tile| and |drag_view_|.
   void CalculateNearestTileForVertex(
       const gfx::Point& vertex, Index* nearest_tile, int* d_min);
 
   // Returns the bounds of the tile in which |point| is enclosed if there
   // is a valid item sits on the tile.
@@ skipping 100 matching lines @@
 #if defined(OS_WIN)
   // Created when a drag is started (ie: drag exceeds the drag threshold), but
   // not Run() until supplied with a shortcut path.
   scoped_refptr<SynchronousDrag> synchronous_drag_;
 
   // Whether to use SynchronousDrag to support dropping to task bar etc.
   bool use_synchronous_drag_;
 #endif
 
   Pointer drag_pointer_;
-  Index drop_target_;
+  Index reorder_drop_target_;

[Matt Giuca, 2014/09/11 03:35:39]

Comments here.

In particular, say that reorder_drop_target_ is only valid when drop_attempt_ is
DROP_FOR_REORDER, and so on.

[calamity, 2014/09/11 07:05:17]

Done.

+  Index folder_drop_target_;
   DropAttempt drop_attempt_;
 
   // Timer for re-ordering the |drop_target_| and |drag_view_|.
   base::OneShotTimer<AppsGridView> reorder_timer_;
 
   // Timer for dropping |drag_view_| into the folder containing
   // the |drop_target_|.
   base::OneShotTimer<AppsGridView> folder_dropping_timer_;
 
   // Timer for dragging a folder item out of folder container ink bubble.
@@ skipping 30 matching lines @@
 
   // True if the drag_view_ item is a folder item being dragged for reparenting.
   bool dragging_for_reparent_item_;
 
   DISALLOW_COPY_AND_ASSIGN(AppsGridView);
 };
 
 }  // namespace app_list
 
 #endif  // UI_APP_LIST_VIEWS_APPS_GRID_VIEW_H_